From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:42985)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1Su5GU-0004Lj-OI
	for qemu-devel@nongnu.org; Wed, 25 Jul 2012 13:20:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1Su5GT-0001el-KU
	for qemu-devel@nongnu.org; Wed, 25 Jul 2012 13:20:50 -0400
Received: from paradis.irqsave.net ([109.190.18.76]:50770)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1Su5GT-0001ef-AW
	for qemu-devel@nongnu.org; Wed, 25 Jul 2012 13:20:49 -0400
Date: Wed, 25 Jul 2012 19:20:43 +0200
From: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>
Message-ID: <20120725172043.GF12455@irqsave.net>
References: <1343219765-12297-1-git-send-email-benoit@irqsave.net>
	<1343219765-12297-3-git-send-email-benoit@irqsave.net>
	<501020E1.3010104@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <501020E1.3010104@redhat.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH V3 2/3] block: Use
 bdrv_get_backing_file_ancestors_count()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: kwolf@redhat.com, benoit.canet@gmail.com, stefanha@linux.vnet.ibm.com, stefanha@gmail.com, qemu-devel@nongnu.org, pbonzini@redhat.com

Le Wednesday 25 Jul 2012 =E0 10:37:53 (-0600), Eric Blake a =E9crit :
> On 07/25/2012 06:36 AM, benoit.canet@gmail.com wrote:
> > From: Beno=EEt Canet <benoit@irqsave.net>
> >=20
> > Use the dedicated counting function in qmp_query_block in order to
> > propagate the backing file count to HMP.
> >=20
> > Signed-off-by: Benoit Canet <benoit@irqsave.net>
>=20
> > +++ b/qapi-schema.json
> > @@ -398,6 +398,8 @@
> >  #
> >  # @backing_file: #optional the name of the backing file (for copy-on=
-write)
> >  #
> > +# @backing_file_ancestors_count: #the count of ancestors backing fil=
es (since: 1.2)
>=20
> s/ancestors/ancestor's/ ?
>=20
> s/#//
>=20
> You are making it sound like this is the count of ancestors of the
> backing file (that is, 'base <- sn1 <- sn2' would have a count of 1,
> since there is 1 ancestor of the backing file sn1; and what if I have n=
o
> backing file?), rather than a count of ancestors of this file (base has
> a count of 0, base <- sn1 has a count of 1).  Maybe a better wording is=
:
>=20
> @backing_file_depth: number of files in the backing file chain (since: =
1.2)

I'll change it

Beno=EEt

>=20
> --=20
> Eric Blake   eblake@redhat.com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>=20