From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:33219)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1SuOqM-00074T-MJ
	for qemu-devel@nongnu.org; Thu, 26 Jul 2012 10:15:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1SuOqG-0006Nb-Pz
	for qemu-devel@nongnu.org; Thu, 26 Jul 2012 10:15:10 -0400
Received: from mx1.redhat.com ([209.132.183.28]:32783)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1SuOqG-0006Mc-IK
	for qemu-devel@nongnu.org; Thu, 26 Jul 2012 10:15:04 -0400
Date: Thu, 26 Jul 2012 11:15:39 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20120726111539.2e1a5b8f@doriath.home>
In-Reply-To: <87d33iepys.fsf@blackfin.pond.sub.org>
References: <1343235256-26310-1-git-send-email-lcapitulino@redhat.com>
	<1343235256-26310-7-git-send-email-lcapitulino@redhat.com>
	<87d33iepys.fsf@blackfin.pond.sub.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 06/11] qerror: QERR_AMBIGUOUS_PATH: drop
 %(object) from human msg
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: pbonzini@redhat.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com

On Thu, 26 Jul 2012 13:12:11 +0200
Markus Armbruster <armbru@redhat.com> wrote:

> Luiz Capitulino <lcapitulino@redhat.com> writes:
> 
> > Actually, renames it to 'object'. This must be what the original author
> > meant to write, as there's no 'object' in the error's data member.
> >
> > Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> > ---
> >  qerror.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/qerror.c b/qerror.c
> > index 3d8ba2a..01d2493 100644
> > --- a/qerror.c
> > +++ b/qerror.c
> > @@ -49,7 +49,7 @@ static const QErrorStringTable qerror_table[] = {
> >      },
> >      {
> >          .error_fmt = QERR_AMBIGUOUS_PATH,
> > -        .desc      = "Path '%(path)' does not uniquely identify a %(object)"
> > +        .desc      = "Path '%(path)' does not uniquely identify a object"
> >      },
> >      {
> >          .error_fmt = QERR_BAD_BUS_FOR_DEVICE,
> 
> "an object", please.

Fixed for v3, thanks.