From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:44423)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1SuPO6-0000VV-QA
	for qemu-devel@nongnu.org; Thu, 26 Jul 2012 10:50:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1SuPNw-00010J-8i
	for qemu-devel@nongnu.org; Thu, 26 Jul 2012 10:50:02 -0400
Received: from mx1.redhat.com ([209.132.183.28]:31763)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1SuPNw-00010C-0a
	for qemu-devel@nongnu.org; Thu, 26 Jul 2012 10:49:52 -0400
Date: Thu, 26 Jul 2012 11:50:27 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20120726115027.2ac4eaab@doriath.home>
In-Reply-To: <87mx2md9db.fsf@blackfin.pond.sub.org>
References: <1343235256-26310-1-git-send-email-lcapitulino@redhat.com>
	<1343235256-26310-11-git-send-email-lcapitulino@redhat.com>
	<87mx2md9db.fsf@blackfin.pond.sub.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 10/11] qerror: switch to qapi generated
 error macros and table
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: pbonzini@redhat.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com

On Thu, 26 Jul 2012 13:56:00 +0200
Markus Armbruster <armbru@redhat.com> wrote:

> Luiz Capitulino <lcapitulino@redhat.com> writes:
> 
> > Previous commits added qapi infrastructure to automatically generate
> > qerror macros and the qerror table from qapi-schema-errors.json.
> >
> > This commit drops the current error macros from qerror.h and the error
> > table from qerror.c and use the generated ones instead.
> >
> > Please, note that qapi-error.c is actually _included_ by qerror.c.
> > This is hacky, but the alternative is to make the table private to
> > qapi-error.c and generate functions to return table entries. I think that
> > doesn't pay much off.
> 
> Functions?  Why can't you simply put
> 
>     const QErrorStringTable qerror_table[NUMBER_OF_ERRORS];
> 
> into qapi-errors.h?

Because it's included by qerror.h, which is included by several files.

I don't like much the idea of including a .c file, but on the other hand
it's only included by qerror.c and qerror.c will probably die in the
near future.

> 
> With a literal number instead of NUMBER_OF_ERRORS.  If you suffer from
> literal-phobia, you can also #define it instead.
>