From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:59819)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1SuSzB-0002rj-Rq
	for qemu-devel@nongnu.org; Thu, 26 Jul 2012 14:40:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1SuSz9-0006Vg-WF
	for qemu-devel@nongnu.org; Thu, 26 Jul 2012 14:40:33 -0400
Received: from mx1.redhat.com ([209.132.183.28]:42251)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1SuSz9-0006VY-ND
	for qemu-devel@nongnu.org; Thu, 26 Jul 2012 14:40:31 -0400
Date: Thu, 26 Jul 2012 13:49:25 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20120726134925.5d9512b2@doriath.home>
In-Reply-To: <5011650D.1050100@redhat.com>
References: <1343127865-16608-1-git-send-email-pbonzini@redhat.com>
	<1343127865-16608-3-git-send-email-pbonzini@redhat.com>
	<501161A4.6000800@redhat.com> <5011650D.1050100@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 02/47] qerror/block: introduce
	QERR_BLOCK_JOB_NOT_ACTIVE
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, jcody@redhat.com, eblake@redhat.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com

On Thu, 26 Jul 2012 17:41:01 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:

> Il 26/07/2012 17:26, Kevin Wolf ha scritto:
> >> The DeviceNotActive error is not a particularly good match, add
> >> > a separate one.
> >> > 
> >> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> > Luiz, what do you think about this one? It seems to contradict the idea
> > of having only few error classes and free form error descriptions.
> 
> I agree, but that's what we have to live with for now...

Why don't you add QERR_INVALID_STATE then?

> 
> > What's the error class that we should really have here? A general
> > QERR_NOT_ACTIVE?
> 
> See my proposal here:
> http://lists.nongnu.org/archive/html/qemu-devel/2012-07/msg00061.html
> (totally ignored ;)).
> 
> This would be QERR_INVALID_STATE (quoting from that message:
> "InvalidStateError is generally caused by the interaction with other
> commands, could be fixed by sending some commands and retrying").
> 
> Paolo
>