qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Richard W.M. Jones" <rjones@redhat.com>
To: anthony@codemonkey.ws
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Plan for error handling in QMP
Date: Thu, 26 Jul 2012 22:16:05 +0100	[thread overview]
Message-ID: <20120726211605.GA4000@amd.home.annexia.org> (raw)
In-Reply-To: <87ipdacrhj.fsf@codemonkey.ws>

On Thu, Jul 26, 2012 at 01:22:15PM -0500, anthony@codemonkey.ws wrote:
> We had a violent^Wheated discussion on IRC about how to move forward
> with Luiz's proposed error series.  I think we reached consensus.  This
> note attempts to outline that.
> 
> Principles
> ----------
> 1. Errors should be free formed strings with a class code
> 
> 2. There should be a small number of class codes (10-15) added
>    strictly when there are specific users of a code.

FWIW this is roughly the same scheme that libguestfs uses to report
errors: string + error code.  It's been quite successful, and IMHO is
much better than the large and ill-defined 'virterror' struct that
libvirt returns.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://et.redhat.com/~rjones/virt-top

  parent reply	other threads:[~2012-07-26 21:16 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-26 18:22 [Qemu-devel] Plan for error handling in QMP anthony
2012-07-26 18:43 ` Luiz Capitulino
2012-07-26 18:47   ` Luiz Capitulino
2012-07-26 21:08     ` Anthony Liguori
2012-07-26 21:14       ` Luiz Capitulino
2012-07-26 22:47         ` Anthony Liguori
2012-07-27 14:24           ` Luiz Capitulino
2012-07-26 20:41 ` Eric Blake
2012-07-27  7:08   ` Paolo Bonzini
2012-07-26 21:16 ` Richard W.M. Jones [this message]
2012-07-27  7:08 ` Markus Armbruster
2012-07-27  7:11 ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120726211605.GA4000@amd.home.annexia.org \
    --to=rjones@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).