From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43494) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SuiAD-0005uB-Kx for qemu-devel@nongnu.org; Fri, 27 Jul 2012 06:53:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SuiA7-0005zm-Qw for qemu-devel@nongnu.org; Fri, 27 Jul 2012 06:52:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31906) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SuiA7-0005zh-Hv for qemu-devel@nongnu.org; Fri, 27 Jul 2012 06:52:51 -0400 Date: Fri, 27 Jul 2012 11:52:45 +0100 From: "Daniel P. Berrange" Message-ID: <20120727105245.GT2225@redhat.com> References: <1343384448-21828-1-git-send-email-xiawenc@linux.vnet.ibm.com> <20120727103352.GR2225@redhat.com> <50127251.9060203@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <50127251.9060203@redhat.com> Subject: Re: [Qemu-devel] [PATCH] let qemu-img info genereate json output Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: aliguori@us.ibm.com, Wenchao Xia , stefanha@linux.vnet.ibm.com, qemu-devel@nongnu.org On Fri, Jul 27, 2012 at 12:49:53PM +0200, Paolo Bonzini wrote: > Il 27/07/2012 12:33, Daniel P. Berrange ha scritto: > > #qemu-img info -j /var/lib/libvirt/images/bar.qcow2 > > { > > "information": { > > "actual_size": "139264", > > "fmt": "qcow2", > > "virtual_size": "10485760", > > "filename": "/var/lib/libvirt/images/bar.qcow2", > > "cluster_size": 65536, > > "encrypted": 0, > > "snapshot_list": [ > > ], > > "dirty_flag": 0, > > "backing_filename": "/dev/sda1" > > }, > > "return": 0 > > } > > > > IIUC,the 'return' element here is just duplicating the qemu-img > > exit status. I think this is rather dubious, and would rather > > just see the stuff in the 'information' sub-block be output > > directly. It also seems to forget to mention the backing > > file format. > > I wonder if we could add this also to the QEMU monitor ("info > block-image foo"), so that the code would be shared between qemu-img.c > and QEMU. It would certainly make sense to have the code & data format shared between the two, so apps don't need to have 2 different JSON parsers Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|