From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:52420)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1SulSd-0003oh-W2
	for qemu-devel@nongnu.org; Fri, 27 Jul 2012 10:24:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1SulSU-00008Y-FF
	for qemu-devel@nongnu.org; Fri, 27 Jul 2012 10:24:11 -0400
Received: from mx1.redhat.com ([209.132.183.28]:36593)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1SulSU-00008S-7b
	for qemu-devel@nongnu.org; Fri, 27 Jul 2012 10:24:02 -0400
Date: Fri, 27 Jul 2012 11:24:37 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20120727112437.4fadfbef@doriath.home>
In-Reply-To: <87394e9m2q.fsf@codemonkey.ws>
References: <87ipdacrhj.fsf@codemonkey.ws>
	<20120726154358.69eee026@doriath.home>
	<20120726154711.30784ba5@doriath.home>
	<87394e1b89.fsf@codemonkey.ws>
	<20120726181408.5e63efe1@doriath.home>
	<87394e9m2q.fsf@codemonkey.ws>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] Plan for error handling in QMP
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Kevin Wolf <kwolf@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>

On Thu, 26 Jul 2012 17:47:25 -0500
Anthony Liguori <anthony@codemonkey.ws> wrote:

> Luiz Capitulino <lcapitulino@redhat.com> writes:
> 
> > On Thu, 26 Jul 2012 16:08:54 -0500
> > Anthony Liguori <anthony@codemonkey.ws> wrote:
> >
> >> Luiz Capitulino <lcapitulino@redhat.com> writes:
> >> 
> >> > On Thu, 26 Jul 2012 15:43:58 -0300
> >> > Luiz Capitulino <lcapitulino@redhat.com> wrote:
> >> >
> >> >> On Thu, 26 Jul 2012 13:22:15 -0500
> >> >> anthony@codemonkey.ws wrote:
> >> >> 
> >> >> > 
> >> >> > Hi,
> >> >> > 
> >> >> > We had a violent^Wheated discussion on IRC about how to move forward
> >> >> > with Luiz's proposed error series.  I think we reached consensus.  This
> >> >> > note attempts to outline that.
> >> >> 
> >> >> This looks great to me, violent^W heated discussions can be so productive :)
> >> >> 
> >> >> > 
> >> >> > Principles
> >> >> > ----------
> >> >> > 1. Errors should be free formed strings with a class code
> >> >> > 
> >> >> > 2. There should be a small number of class codes (10-15) added
> >> >> >    strictly when there are specific users of a code.
> >> >
> >> > Btw, do we have a listing of those 10-15 errors already?
> >> 
> >> See the clause: "added strictly when there are specific users".
> >> 
> >> Users means consumers.  So don't add an error type until someone cares
> >> to differientiate error reasons.
> >
> > What I meant is that, for 1.2 we want to reduce from 71 error codes to 10-15,
> > right? If that's right what are the 10-15 errors that won't be dropped?
> >
> > Or did I misunderstand?
> 
> I meant drop it down to 5-6.  The existing errors that libvirt cares
> about plus an UnknownError.  #define all existing error codes to
> UnknownError and then at our leisure, we can introduce more generic
> classes and refactor errors incrementally.

That's great, I've already started working on this and should post the
series soon.