qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrange" <berrange@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Anthony Liguori <aliguori@us.ibm.com>,
	Eric Blake <eblake@redhat.com>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] vl: add -libvirt-caps option for libvirt to stop parsing help output
Date: Fri, 27 Jul 2012 12:49:16 +0100	[thread overview]
Message-ID: <20120727114916.GU2225@redhat.com> (raw)
In-Reply-To: <87394dqwh4.fsf@blackfin.pond.sub.org>

On Fri, Jul 27, 2012 at 01:23:03PM +0200, Markus Armbruster wrote:
> 
> Assuming version X (according to query-version) supports no less than
> upstream version X sounds fair.
> 
> If a command line option has a corresponding QMP command, probing QMP
> for the feature suffices.  For instance, query-devices gives you devices
> for -device.
> 
> I'm afraid there could still be an occasional need for probing the
> command line.  A simple, machine-readable command line self-description
> could satisfy it.  Something like:
> 
> - query-cmdline-options: JSON representation of qemu_options[], with
>   unnecessary detail elided.  Basically option name and whether it takes
>   an argument.
> 
> For options with a QemuOpts argument, we may want to add argument
> self-description.  Basically its QemuOptsList, with unnecessary detail
> elided.  Non-QemuOpts arguments don't get that.  New structured option
> arguments should use QemuOpts anyway.
> 
> Some users might prefer to get this via a command line option rather
> than a QMP command.  They should ask for it.

In my original proposal from 2 years back, I actually exposed a number
of QMP query-XXX commands via a -capabilities XXXX command line args.
On revisiting it though, I think that since we'll want to ask for
info on many different aspects, it is easier just to use QMP directly
rather than string together various command line args upfront, or
invoke QEMU multiple times.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

  reply	other threads:[~2012-07-27 11:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-25 19:47 [Qemu-devel] [PATCH] vl: add -libvirt-caps option for libvirt to stop parsing help output Anthony Liguori
2012-07-25 22:12 ` Eric Blake
2012-07-25 23:10   ` Anthony Liguori
2012-07-26 12:47 ` Daniel P. Berrange
2012-07-26 13:07   ` Daniel P. Berrange
2012-07-26 14:10     ` Anthony Liguori
2012-07-27 15:04       ` Paolo Bonzini
2012-07-27 15:27         ` Anthony Liguori
2012-07-27 11:23   ` Markus Armbruster
2012-07-27 11:49     ` Daniel P. Berrange [this message]
2012-07-27 12:19       ` Markus Armbruster
2012-07-27 16:35     ` Daniel P. Berrange
2012-07-27 17:17       ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120727114916.GU2225@redhat.com \
    --to=berrange@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=armbru@redhat.com \
    --cc=eblake@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).