From: Alon Levy <alevy@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: yhalperi@redhat.com, qemu-devel@nongnu.org, kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC
Date: Sat, 28 Jul 2012 12:20:05 +0200 [thread overview]
Message-ID: <20120728102005.GJ29361@garlic.redhat.com> (raw)
In-Reply-To: <CAAu8pHtqYEQ7WruVAVcpaZDRdx0sO3182wcofmqPuOGBtf5+2A@mail.gmail.com>
On Sat, Jul 28, 2012 at 09:01:11AM +0000, Blue Swirl wrote:
> > + // - this is not a guest io, but a reply, so async_io isn't set.
>
> Please use checkpatch.pl to avoid C99 comments.
>
Doh, I must have missed it (I do), will fix, thanks.
Alon
next prev parent reply other threads:[~2012-07-28 10:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-23 13:08 [Qemu-devel] [PATCH 1/2] qxl: disallow unknown revisions Alon Levy
2012-07-23 13:08 ` [Qemu-devel] [PATCH 2/2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC Alon Levy
2012-07-23 16:33 ` [Qemu-devel] [PATCH v2] " Alon Levy
2012-07-25 9:00 ` Yonit Halperin
2012-07-25 17:29 ` Alon Levy
2012-07-26 5:26 ` Yonit Halperin
2012-07-28 8:56 ` Alon Levy
2012-07-28 9:01 ` Blue Swirl
2012-07-28 10:20 ` Alon Levy [this message]
2012-07-28 10:23 ` [Qemu-devel] [PATCH v3] " Alon Levy
2012-08-06 7:31 ` Gerd Hoffmann
2012-08-09 13:41 ` Alon Levy
2012-08-09 13:50 ` Gerd Hoffmann
2012-08-09 14:18 ` Alon Levy
2012-08-09 14:21 ` [Qemu-devel] [PATCH v4 1/2] " Alon Levy
2012-08-09 14:21 ` [Qemu-devel] [PATCH v4 2/2] configure: print spice-protocol and spice-server versions Alon Levy
2012-08-15 8:23 ` [Qemu-devel] [PATCH v4 1/2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC Gerd Hoffmann
2012-08-15 10:32 ` Alon Levy
2012-08-15 10:43 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120728102005.GJ29361@garlic.redhat.com \
--to=alevy@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yhalperi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).