qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Richard W.M. Jones" <rjones@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-devel] [PATCH] configure: fix libcap detection
Date: Mon, 30 Jul 2012 23:04:57 +0100	[thread overview]
Message-ID: <20120730220457.GC4000@amd.home.annexia.org> (raw)
In-Reply-To: <1343648493-27905-1-git-send-email-avi@redhat.com>

On Mon, Jul 30, 2012 at 02:41:33PM +0300, Avi Kivity wrote:
>  - avoid assigned-but-not-used error
>  - avoid missing return error
> 
> Signed-off-by: Avi Kivity <avi@redhat.com>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index 7767aca..5fb449d 100755
> --- a/configure
> +++ b/configure
> @@ -2099,7 +2099,7 @@ if test "$cap" != "no" ; then
>    cat > $TMPC <<EOF
>  #include <stdio.h>
>  #include <sys/capability.h>
> -int main(void) { cap_t caps; caps = cap_init(); }
> +int main(void) { cap_t caps; caps = cap_init(); (void)caps; return 0; }
>  EOF
>    if compile_prog "" "-lcap" ; then
>      cap=yes
> -- 
> 1.7.11.3
> 

I tested this patch and it fixes 9p detection for me.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into Xen guests.
http://et.redhat.com/~rjones/virt-p2v

  parent reply	other threads:[~2012-07-30 22:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-30 11:41 [Qemu-devel] [PATCH] configure: fix libcap detection Avi Kivity
2012-07-30 12:58 ` Peter Maydell
2012-07-30 22:04 ` Richard W.M. Jones [this message]
2012-07-31  6:52 ` Aneesh Kumar K.V
2012-07-31 16:33   ` Stefan Weil
2012-07-31 16:40     ` Peter Maydell
2012-07-31 17:06       ` Blue Swirl
2012-07-31 17:56       ` Blue Swirl
2012-07-31 17:59         ` Peter Maydell
2012-07-31 17:35     ` Aneesh Kumar K.V

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120730220457.GC4000@amd.home.annexia.org \
    --to=rjones@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=avi@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).