qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-devel] [PATCHv2] qemu: add .exrc
Date: Tue, 31 Jul 2012 03:30:02 +0300	[thread overview]
Message-ID: <20120731003002.GB17922@redhat.com> (raw)
In-Reply-To: <CAAu8pHuhFt9B13xHX6bHgsH+PkbmhkKZYvszbP-iYBAqQOLnMQ@mail.gmail.com>

On Mon, Jul 30, 2012 at 03:03:56PM +0000, Blue Swirl wrote:
> On Sun, Jul 29, 2012 at 2:08 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> > On Thu, Jul 19, 2012 at 05:48:32PM +0300, Michael S. Tsirkin wrote:
> >> I've been using this to get correct indenting with vim
> >> in qemu for a while, but it's a bit easier if we
> >> put the settings in the central place.
> >> Note that
> >> 1. you still need to enable 'exrc' and 'secure'
> >>    options in your vimrc for these settings to take effect.
> >> 2. you can create a .vimrc file if 'exrc' is on but there's
> >>    need to bypass this configuration.
> >>
> >> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> >
> > So two -1 and one +1, given +1 seems to be the only one from a vim user
> > I'm inclined to go ahead with this one as others aren't likely to be
> > negatively affected...
> >
> >> ---
> >>
> >> Changes from v1:
> >>     added some comments explaining usage
> >>
> >>  .exrc | 7 +++++++
> >>  1 file changed, 7 insertions(+)
> >>  create mode 100644 .exrc
> >>
> >> diff --git a/.exrc b/.exrc
> >> new file mode 100644
> >> index 0000000..37755ed
> >> --- /dev/null
> >> +++ b/.exrc
> >> @@ -0,0 +1,7 @@
> >> +"VIM settings to match QEMU coding style.  They are activated by adding the
> >> +"following settings (without the " symbol) as last two lines in $HOME/.vimrc:
> >> +"set secure
> >> +"set exrc
> 
> Doesn't this make VIM to read commands from all files edited, not just
> files of QEMU? Aren't there security implications from this
> recommendation?

That is why you need to set "secure" option.
Another way is to manually source this file,
I will add this explanation.

> >> +set expandtab
> >> +set shiftwidth=4
> >> +set smarttab
> >> --
> >> MST
> >

      reply	other threads:[~2012-07-31  0:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-19 14:48 [Qemu-devel] [PATCHv2] qemu: add .exrc Michael S. Tsirkin
2012-07-29 14:08 ` Michael S. Tsirkin
2012-07-30 15:03   ` Blue Swirl
2012-07-31  0:30     ` Michael S. Tsirkin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120731003002.GB17922@redhat.com \
    --to=mst@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=blauwirbel@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).