From: Luiz Capitulino <lcapitulino@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: blauwirbel@gmail.com, qemu-devel@nongnu.org,
Michael Roth <mdroth@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 3/5] qapi: avoid reserved word restrict
Date: Tue, 31 Jul 2012 09:58:34 -0300 [thread overview]
Message-ID: <20120731095834.517c37bc@doriath.home> (raw)
In-Reply-To: <5017892B.2070609@redhat.com>
On Tue, 31 Jul 2012 09:28:43 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:
> Il 30/07/2012 18:04, blauwirbel@gmail.com ha scritto:
> > From: Blue Swirl <blauwirbel@gmail.com>
> >
> > Clang compiler complained about use of reserved word 'restrict' in SLIRP
> > and QAPI.
> >
> > Rename 'restrict' to 'restricted' which also matches other SLIRP code.
>
> Can't do it, this changes the command-line option.
>
> Luiz, Michael, any ideas?
I'm not sure how complicated it would be to implement this, but we could add
a 'bind' keyword to the type dict to control mapping between protocol names
and generated variable names. Like this:
{ 'type': 'NetdevUserOptions',
'data': {
'*hostname': 'str',
'*restrict': 'bool',
...
'*hostfwd': ['String'],
'*guestfwd': ['String'] },
'bind': { 'restrict': 'restricted' } }
next prev parent reply other threads:[~2012-07-31 12:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-30 16:04 [Qemu-devel] [PATCH 0/5] Clang patches blauwirbel
2012-07-30 16:04 ` [Qemu-devel] [PATCH 1/5] sparc: fix floppy TC line setup blauwirbel
2012-07-30 16:04 ` [Qemu-devel] [PATCH 2/5] sparc: fix expression with uninitialized initial value blauwirbel
2012-07-30 16:13 ` Peter Maydell
2012-07-30 16:59 ` Andreas Färber
2012-07-30 17:09 ` Peter Maydell
2012-07-30 17:20 ` Blue Swirl
2012-07-30 17:57 ` Peter Maydell
2012-07-30 16:04 ` [Qemu-devel] [PATCH 3/5] qapi: avoid reserved word restrict blauwirbel
2012-07-31 7:28 ` Paolo Bonzini
2012-07-31 12:58 ` Luiz Capitulino [this message]
2012-07-31 16:56 ` Blue Swirl
2012-07-31 18:55 ` Michael Roth
2012-07-31 20:38 ` Blue Swirl
2012-07-31 22:30 ` Michael Roth
2012-08-01 6:45 ` Paolo Bonzini
2012-08-01 17:35 ` Blue Swirl
2012-08-01 0:01 ` Anthony Liguori
2012-07-30 16:04 ` [Qemu-devel] [PATCH 4/5] user: fix accidental AREG0 use blauwirbel
2012-07-30 16:04 ` [Qemu-devel] [PATCH 5/5] configure: disable a few Clang compiler warnings blauwirbel
2012-07-30 16:56 ` Stefan Weil
2012-07-30 17:23 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120731095834.517c37bc@doriath.home \
--to=lcapitulino@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).