From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:56707)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1SwC1U-00053f-4K
	for qemu-devel@nongnu.org; Tue, 31 Jul 2012 08:58:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1SwC1Q-0002v5-3o
	for qemu-devel@nongnu.org; Tue, 31 Jul 2012 08:58:04 -0400
Received: from mx1.redhat.com ([209.132.183.28]:44872)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1SwC1P-0002v1-Sf
	for qemu-devel@nongnu.org; Tue, 31 Jul 2012 08:58:00 -0400
Date: Tue, 31 Jul 2012 09:58:34 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20120731095834.517c37bc@doriath.home>
In-Reply-To: <5017892B.2070609@redhat.com>
References: <cover.1343664167.git.blauwirbel@gmail.com>
	<a1ac6a7644eb59203e1d3904baecece82399ab61.1343664167.git.blauwirbel@gmail.com>
	<5017892B.2070609@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/5] qapi: avoid reserved word restrict
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: blauwirbel@gmail.com, qemu-devel@nongnu.org, Michael Roth <mdroth@linux.vnet.ibm.com>

On Tue, 31 Jul 2012 09:28:43 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:

> Il 30/07/2012 18:04, blauwirbel@gmail.com ha scritto:
> > From: Blue Swirl <blauwirbel@gmail.com>
> > 
> > Clang compiler complained about use of reserved word 'restrict' in SLIRP
> > and QAPI.
> > 
> > Rename 'restrict' to 'restricted' which also matches other SLIRP code.
> 
> Can't do it, this changes the command-line option.
> 
> Luiz, Michael, any ideas?

I'm not sure how complicated it would be to implement this, but we could add
a 'bind' keyword to the type dict to control mapping between protocol names
and generated variable names. Like this:

{ 'type': 'NetdevUserOptions',
  'data': {
    '*hostname':  'str',
    '*restrict':  'bool',
    ...
    '*hostfwd':   ['String'],
    '*guestfwd':  ['String'] },

  'bind': { 'restrict': 'restricted' } }