From: Stefan Hajnoczi <stefanha@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-trivial@nongnu.org, Stefan Weil <sw@weilnetz.de>,
Jan Kiszka <jan.kiszka@siemens.com>,
qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] Makefile: Avoid explicit list of directories in clean target
Date: Tue, 31 Jul 2012 14:25:56 +0100 [thread overview]
Message-ID: <20120731132556.GA16269@stefanha-thinkpad.localdomain> (raw)
In-Reply-To: <1343739695-7757-1-git-send-email-peter.maydell@linaro.org>
On Tue, Jul 31, 2012 at 02:01:35PM +0100, Peter Maydell wrote:
> Avoid having an explicit list of directories in the 'clean'
> target by using 'find' to remove all .o and .d files instead.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> I figured that (unlike Makefile.target) we should probably take
> the xargs route here since otherwise the rm command line is huge...
>
> There's also an argument that there's not much point having a clean
> target in Makefile.target when this one blows away most of it anyway.
>
> Makefile | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
Looks fine but waiting for others to review in case there is a subtlety
that affects some build environments.
Stefan
next prev parent reply other threads:[~2012-07-31 13:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-31 13:01 [Qemu-devel] [PATCH] Makefile: Avoid explicit list of directories in clean target Peter Maydell
2012-07-31 13:25 ` Stefan Hajnoczi [this message]
2012-07-31 14:19 ` Markus Armbruster
2012-07-31 14:21 ` Peter Maydell
2012-07-31 14:35 ` Markus Armbruster
2012-07-31 14:38 ` Daniel P. Berrange
2012-07-31 15:00 ` Peter Maydell
2012-07-31 15:49 ` Stefan Weil
2012-07-31 15:51 ` Peter Maydell
2012-07-31 16:20 ` Stefan Weil
2012-07-31 17:02 ` Blue Swirl
2012-07-31 14:24 ` Eric Blake
2012-08-01 10:28 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120731132556.GA16269@stefanha-thinkpad.localdomain \
--to=stefanha@gmail.com \
--cc=jan.kiszka@siemens.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).