From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51833) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwCSa-0005l9-4p for qemu-devel@nongnu.org; Tue, 31 Jul 2012 09:26:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SwCSW-0003lr-1k for qemu-devel@nongnu.org; Tue, 31 Jul 2012 09:26:04 -0400 Date: Tue, 31 Jul 2012 14:25:56 +0100 From: Stefan Hajnoczi Message-ID: <20120731132556.GA16269@stefanha-thinkpad.localdomain> References: <1343739695-7757-1-git-send-email-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1343739695-7757-1-git-send-email-peter.maydell@linaro.org> Subject: Re: [Qemu-devel] [PATCH] Makefile: Avoid explicit list of directories in clean target List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-trivial@nongnu.org, Stefan Weil , Jan Kiszka , qemu-devel@nongnu.org, patches@linaro.org On Tue, Jul 31, 2012 at 02:01:35PM +0100, Peter Maydell wrote: > Avoid having an explicit list of directories in the 'clean' > target by using 'find' to remove all .o and .d files instead. > > Signed-off-by: Peter Maydell > --- > I figured that (unlike Makefile.target) we should probably take > the xargs route here since otherwise the rm command line is huge... > > There's also an argument that there's not much point having a clean > target in Makefile.target when this one blows away most of it anyway. > > Makefile | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) Looks fine but waiting for others to review in case there is a subtlety that affects some build environments. Stefan