From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41464) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwTef-00084v-JV for qemu-devel@nongnu.org; Wed, 01 Aug 2012 03:47:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SwTee-0004Qj-KQ for qemu-devel@nongnu.org; Wed, 01 Aug 2012 03:47:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:14312) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwTee-0004QQ-Ce for qemu-devel@nongnu.org; Wed, 01 Aug 2012 03:47:40 -0400 Date: Wed, 1 Aug 2012 10:47:35 +0300 From: Gleb Natapov Message-ID: <20120801074735.GK11448@redhat.com> References: <1343241930-9506-1-git-send-email-ehabkost@redhat.com> <20120801011413.GE22937@morn.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120801011413.GE22937@morn.localdomain> Subject: Re: [Qemu-devel] [SeaBIOS PATCH 0/2] Allow non-contiguous APIC IDs (v3) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin O'Connor Cc: Igor Mammedov , seabios@seabios.org, Laszlo Ersek , Eduardo Habkost , qemu-devel@nongnu.org On Tue, Jul 31, 2012 at 09:14:13PM -0400, Kevin O'Connor wrote: > On Wed, Jul 25, 2012 at 03:45:28PM -0300, Eduardo Habkost wrote: > > Changes v2 -> v3: > > - Report I/O APIC ID = 0 on MP-table, too > > > > Changes v1 -> v2: > > - Patch 1/2: cosmetic whitespace change > > - Patch 2/2: use size suffixes on asm instructions on smp.c > > - New patch descriptions > > > > Eduardo Habkost (2): > > report real I/O APIC ID (0) on MADT and MP-table (v3) > > allow CPUs to have non-contiguous Local APIC IDs (v2) > > The series looks okay to me. However, I think Gleb and Avi had some > comments - has that been resolved now? > No, but the comment is very minor and can be resolved by follow up patch if ever. -- Gleb.