From: Gleb Natapov <gleb@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: peter.maydell@linaro.org, aliguori@us.ibm.com,
ehabkost@redhat.com, jan.kiszka@siemens.com, mtosatti@redhat.com,
qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com,
blauwirbel@gmail.com, avi@redhat.com, pbonzini@redhat.com,
afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH 0/2 v3] target-i386: refactor reset handling and move it into cpu.c
Date: Wed, 1 Aug 2012 11:13:08 +0300 [thread overview]
Message-ID: <20120801081308.GL11448@redhat.com> (raw)
In-Reply-To: <1343049748-11539-1-git-send-email-imammedo@redhat.com>
Looks good to me.
On Mon, Jul 23, 2012 at 03:22:26PM +0200, Igor Mammedov wrote:
> v2:
> ommited moving of x86_cpu_realize() from cpu_x86_init() to pc_new_cpu(),
> to keep cpu_init implementation in -softmmu and -user targets the same
> in single place and maintanable.
>
> v3:
> reuse cpu_is_bsp() rather than open code check if apicbase has BSP bit set
>
> tree for testing:
> https://github.com/imammedo/qemu/tree/x86_reset_v3
>
> comiple & run tested with x86_64-linux-user, x86_64-softmmu targets
>
> Igor Mammedov (2):
> target-i386: move cpu halted decision into x86_cpu_reset
> target-i386: move cpu_reset and reset callback to cpu.c
>
> hw/apic.h | 5 ++++-
> hw/apic_common.c | 16 +++++++++++++---
> hw/pc.c | 18 +-----------------
> target-i386/cpu.c | 30 ++++++++++++++++++++++++++++++
> target-i386/helper.c | 1 -
> target-i386/kvm.c | 4 +++-
> 6 files changed, 51 insertions(+), 23 deletions(-)
--
Gleb.
next prev parent reply other threads:[~2012-08-01 8:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-23 13:22 [Qemu-devel] [PATCH 0/2 v3] target-i386: refactor reset handling and move it into cpu.c Igor Mammedov
2012-07-23 13:22 ` [Qemu-devel] [PATCH 1/2] target-i386: move cpu halted decision into x86_cpu_reset Igor Mammedov
2012-08-01 14:00 ` Andreas Färber
2012-08-02 10:11 ` Igor Mammedov
2012-07-23 13:22 ` [Qemu-devel] [PATCH 2/2] target-i386: move cpu_reset and reset callback to cpu.c Igor Mammedov
2012-08-01 14:09 ` Andreas Färber
2012-08-01 8:13 ` Gleb Natapov [this message]
2012-08-01 15:43 ` [Qemu-devel] [PATCH 0/2 v3] target-i386: refactor reset handling and move it into cpu.c Anthony Liguori
2012-08-01 15:50 ` Andreas Färber
2012-08-01 18:25 ` Anthony Liguori
2012-08-01 19:35 ` Andreas Färber
2012-08-01 20:02 ` Anthony Liguori
2012-08-01 20:16 ` Andreas Färber
2012-08-01 20:47 ` Anthony Liguori
2012-08-01 21:25 ` Andreas Färber
2012-08-01 21:43 ` Peter Maydell
2012-08-01 22:15 ` Andreas Färber
2012-08-02 11:19 ` Igor Mammedov
2012-08-01 20:57 ` Andreas Färber
2012-08-01 21:19 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120801081308.GL11448@redhat.com \
--to=gleb@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).