From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53442) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwU3V-0004mH-H3 for qemu-devel@nongnu.org; Wed, 01 Aug 2012 04:13:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SwU3P-0004t4-SW for qemu-devel@nongnu.org; Wed, 01 Aug 2012 04:13:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6075) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwU3P-0004t0-KG for qemu-devel@nongnu.org; Wed, 01 Aug 2012 04:13:15 -0400 Date: Wed, 1 Aug 2012 11:13:08 +0300 From: Gleb Natapov Message-ID: <20120801081308.GL11448@redhat.com> References: <1343049748-11539-1-git-send-email-imammedo@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1343049748-11539-1-git-send-email-imammedo@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/2 v3] target-i386: refactor reset handling and move it into cpu.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, ehabkost@redhat.com, jan.kiszka@siemens.com, mtosatti@redhat.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, avi@redhat.com, pbonzini@redhat.com, afaerber@suse.de Looks good to me. On Mon, Jul 23, 2012 at 03:22:26PM +0200, Igor Mammedov wrote: > v2: > ommited moving of x86_cpu_realize() from cpu_x86_init() to pc_new_cpu(), > to keep cpu_init implementation in -softmmu and -user targets the same > in single place and maintanable. > > v3: > reuse cpu_is_bsp() rather than open code check if apicbase has BSP bit set > > tree for testing: > https://github.com/imammedo/qemu/tree/x86_reset_v3 > > comiple & run tested with x86_64-linux-user, x86_64-softmmu targets > > Igor Mammedov (2): > target-i386: move cpu halted decision into x86_cpu_reset > target-i386: move cpu_reset and reset callback to cpu.c > > hw/apic.h | 5 ++++- > hw/apic_common.c | 16 +++++++++++++--- > hw/pc.c | 18 +----------------- > target-i386/cpu.c | 30 ++++++++++++++++++++++++++++++ > target-i386/helper.c | 1 - > target-i386/kvm.c | 4 +++- > 6 files changed, 51 insertions(+), 23 deletions(-) -- Gleb.