From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:49781)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kmshanah@disenchant.net>) id 1SwkHj-0008Rs-CS
	for qemu-devel@nongnu.org; Wed, 01 Aug 2012 21:33:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kmshanah@disenchant.net>) id 1SwkHi-0004KO-8F
	for qemu-devel@nongnu.org; Wed, 01 Aug 2012 21:33:07 -0400
Received: from ipmail06.adl2.internode.on.net ([150.101.137.129]:9964)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kmshanah@disenchant.net>) id 1SwkHh-0004Jc-Sc
	for qemu-devel@nongnu.org; Wed, 01 Aug 2012 21:33:06 -0400
Date: Thu, 2 Aug 2012 11:02:42 +0930
From: Kevin Shanahan <kmshanah@disenchant.net>
Message-ID: <20120802013242.GA18298@tuon.disenchant.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Subject: [Qemu-devel] [PATCH] block: Set cdrom device read only flag
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>

Set the block driver read_only flag for cdrom devices so that
qmp_change_blockdev does not attempt to open cdrom files in read-write
mode when changing media.

Signed-off-by: Kevin Shanahan <kmshanah@disenchant.net>
---
Proposed fix for https://bugs.launchpad.net/qemu/+bug/1027525

diff -urN qemu-kvm-1.1.1.orig/blockdev.c qemu-kvm-1.1.1/blockdev.c
--- qemu-kvm-1.1.1.orig/blockdev.c	2012-07-16 17:22:03.000000000 +0930
+++ qemu-kvm-1.1.1/blockdev.c	2012-08-02 10:28:40.000000000 +0930
@@ -565,6 +565,7 @@
 	    break;
 	case MEDIA_CDROM:
             dinfo->media_cd = 1;
+            dinfo->bdrv->read_only = 1;
 	    break;
 	}
         break;