From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:55713)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Swvdn-0002Fk-UR
	for qemu-devel@nongnu.org; Thu, 02 Aug 2012 09:40:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Swvdm-0005xm-TX
	for qemu-devel@nongnu.org; Thu, 02 Aug 2012 09:40:39 -0400
Received: from mx1.redhat.com ([209.132.183.28]:59882)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Swvdm-0005xa-LZ
	for qemu-devel@nongnu.org; Thu, 02 Aug 2012 09:40:38 -0400
Date: Thu, 2 Aug 2012 10:41:11 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20120802104111.291984d3@doriath.home>
In-Reply-To: <1343869374-23417-1-git-send-email-lcapitulino@redhat.com>
References: <1343869374-23417-1-git-send-email-lcapitulino@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v1 00/34]: add new error format
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: kwolf@redhat.com, aliguori@us.ibm.com, armbru@redhat.com, mdroth@linux.vnet.ibm.com, qemu-devel@nongnu.org, pbonzini@redhat.com, eblake@redhat.com

On Wed,  1 Aug 2012 22:02:20 -0300
Luiz Capitulino <lcapitulino@redhat.com> wrote:

> Quick summary first, long introduction afterwards.
> 
> From the rfc:
> 
>  o rebased on top of master
>  o dropped patch "qapi: qapi.py: allow the "'" character be escaped"
>  o split patch "qerror: drop qerror_abort()" into two patches
>  o fixed tcp_start_outgoing_migration() not to use QERR_ macros
>  o fixed qemu-ga to use the new error format
>  o dropped more unused stuff
>  o improved several changelogs
> 
> Btw, please take a special look in patches 14/34, 15/34 and 16/34.

I forgot saying here that this actually doesn't when building all targets:

LINK  i386-linux-user/qemu-i386
../qapi/qmp-dispatch.o: In function `qmp_build_error_object':
/home/lcapitulino/work/src/qmp-unstable/qapi/qmp-dispatch.c:114: undefined reference to `ErrorClass_lookup'
collect2: ld returned 1 exit status

This problem was introduced by patch 30/34, but I seem to get a different
build breakage whenever I try to fix it...