From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42491) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwtJl-0002i7-V7 for qemu-devel@nongnu.org; Thu, 02 Aug 2012 07:11:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SwtJf-0002i2-SZ for qemu-devel@nongnu.org; Thu, 02 Aug 2012 07:11:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58880) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwtJf-0002eF-KQ for qemu-devel@nongnu.org; Thu, 02 Aug 2012 07:11:43 -0400 Date: Thu, 2 Aug 2012 12:11:35 +0100 From: "Daniel P. Berrange" Message-ID: <20120802111135.GN2825@redhat.com> References: <1343812186-11594-1-git-send-email-xiawenc@linux.vnet.ibm.com> <50192E62.5020200@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <50192E62.5020200@redhat.com> Subject: Re: [Qemu-devel] [PATCH] [RFC] libqblock draft code v1 Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: aliguori@us.ibm.com, stefanha@linux.vnet.ibm.com, Stefan Hajnoczi , qemu-devel@nongnu.org, pbonzini@redhat.com, Wenchao Xia On Wed, Aug 01, 2012 at 07:25:54AM -0600, Eric Blake wrote: > On 08/01/2012 06:49 AM, Stefan Hajnoczi wrote: > > On Wed, Aug 1, 2012 at 10:09 AM, Wenchao Xia wrote: > >> This patch encapsulate qemu general block layer to provide block > >> services. API are declared in libqblock.h. libqblock-test.c > >> simulate library consumer's behaviors. Make libqblock-test could > >> build the code. > >> For easy this patch does not form a dynamic libarary yet. > >> > >> +++ b/libqblock-test.c > >> @@ -0,0 +1,56 @@ > >> +#include "libqblock.h" > > > > Please include GPLv2+ license headers in new source files you create. > > See existing code like include/qemu/object.h for the license header > > text. > > Actually, LGPLv2+ (or compatible, like BSD), if you plan on making this > a reusable library. GPLv2+ is too strict for libvirt to use directly. NB, i don't see libvirt being able to use this library regardless of license, due to its reliance on glib + abort-on-OOM behaviour Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|