From: "Benoît Canet" <benoit.canet@irqsave.net>
To: Eric Blake <eblake@redhat.com>
Cc: kwolf@redhat.com, pbonzini@redhat.com,
"Benoît Canet" <benoit.canet@gmail.com>,
qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [RFC 01/12] qorum: Add GPL v2+ header file.
Date: Thu, 2 Aug 2012 16:55:59 +0200 [thread overview]
Message-ID: <20120802145559.GD14624@irqsave.net> (raw)
In-Reply-To: <501A88FE.8080309@redhat.com>
Le Thursday 02 Aug 2012 à 08:04:46 (-0600), Eric Blake a écrit :
> On 08/02/2012 04:16 AM, Benoît Canet wrote:
> > Signed-off-by: Benoit Canet <benoit@irqsave.net>
> > ---
> > block/qorum.c | 15 +++++++++++++++
>
> s/qorum/quorum/ for the file name.
ack
>
> > 1 file changed, 15 insertions(+)
> > create mode 100644 block/qorum.c
> >
> > diff --git a/block/qorum.c b/block/qorum.c
> > new file mode 100644
> > index 0000000..3341021
> > --- /dev/null
> > +++ b/block/qorum.c
> > @@ -0,0 +1,15 @@
> > +/*
>
> > + */
> > +
> >
>
> What good is a patch that adds a file whose sole contents are a comment?
> This should not be an independent patch; please squash it into the
> first commit that really adds contents to the file.
ack
>
> --
> Eric Blake eblake@redhat.com +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>
next prev parent reply other threads:[~2012-08-02 14:56 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-02 10:16 [Qemu-devel] [RFC 00/12] Qorum disk image corruption resiliency Benoît Canet
2012-08-02 10:16 ` [Qemu-devel] [RFC 01/12] qorum: Add GPL v2+ header file Benoît Canet
2012-08-02 14:04 ` Eric Blake
2012-08-02 14:55 ` Benoît Canet [this message]
2012-08-02 16:07 ` Andreas Färber
2012-08-02 16:47 ` Benoît Canet
2012-08-02 10:16 ` [Qemu-devel] [RFC 02/12] qorum: Add QorumSingleAIOCB and QorumAIOCB Benoît Canet
2012-08-02 10:16 ` [Qemu-devel] [RFC 03/12] qorum: Create BDRVQorumState and BlkDriver and do init Benoît Canet
2012-08-02 10:16 ` [Qemu-devel] [RFC 04/12] qorum: Add qorum_open() Benoît Canet
2012-08-02 10:16 ` [Qemu-devel] [RFC 05/12] qorum: Add qorum_close() Benoît Canet
2012-08-02 10:16 ` [Qemu-devel] [RFC 06/12] qorum: Add qorum_getlength() Benoît Canet
2012-08-02 10:16 ` [Qemu-devel] [RFC 07/12] qorum: Add qorum_aio_writev and its dependencies Benoît Canet
2012-08-02 10:16 ` [Qemu-devel] [RFC 08/12] blkverify: Make blkverify_iovec_clone() and blkverify_iovec_compare() public Benoît Canet
2012-08-02 10:16 ` [Qemu-devel] [RFC 09/12] qorum: Add qorum_co_flush() Benoît Canet
2012-08-02 10:16 ` [Qemu-devel] [RFC 10/12] qorum: Add qorum_aio_readv Benoît Canet
2012-08-02 10:16 ` [Qemu-devel] [RFC 11/12] qorum: Add qorum mechanism Benoît Canet
2012-08-02 10:16 ` [Qemu-devel] [RFC 12/12] qorum: build feature into QEMU Benoît Canet
2012-08-02 16:06 ` Andreas Färber
2012-08-02 13:17 ` [Qemu-devel] [RFC 00/12] Qorum disk image corruption resiliency Eric Blake
2012-08-02 13:28 ` Benoît Canet
2012-08-02 18:14 ` Anthony Liguori
2012-08-02 19:22 ` Benoît Canet
2012-08-03 9:21 ` Stefan Hajnoczi
2012-08-03 16:14 ` Blue Swirl
2012-08-03 19:11 ` Benoît Canet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120802145559.GD14624@irqsave.net \
--to=benoit.canet@irqsave.net \
--cc=benoit.canet@gmail.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).