From: Luiz Capitulino <lcapitulino@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Jason Baron <jbaron@redhat.com>,
mtosatti@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com,
avi@redhat.com, eblake@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2] memory: add cmd line option, to omit guest memory from qemu core dump
Date: Thu, 2 Aug 2012 15:05:20 -0300 [thread overview]
Message-ID: <20120802150520.049c3261@doriath.home> (raw)
In-Reply-To: <877gti8oca.fsf@codemonkey.ws>
On Wed, 01 Aug 2012 13:21:57 -0500
Anthony Liguori <anthony@codemonkey.ws> wrote:
> > diff --git a/qemu-config.c b/qemu-config.c
> > index 5c3296b..5c2c9a9 100644
> > --- a/qemu-config.c
> > +++ b/qemu-config.c
> > @@ -595,6 +595,10 @@ static QemuOptsList qemu_machine_opts = {
> > .name = "dt_compatible",
> > .type = QEMU_OPT_STRING,
> > .help = "Overrides the \"compatible\" property of the dt root node",
> > + }, {
> > + .name = "dump_guest_core",
>
> "dump-guest-core"
Without your patch to accept both "-" and "_", this will be inconsistent
with the other options.
It's not like I mind too much, but then my patch adding mem-merge could
also be applied (Jan objected because of -/_ mixture).
prev parent reply other threads:[~2012-08-02 18:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-01 16:19 [Qemu-devel] [PATCH v2] memory: add cmd line option, to omit guest memory from qemu core dump Jason Baron
2012-08-01 18:21 ` Anthony Liguori
2012-08-01 18:28 ` Jason Baron
2012-08-01 18:54 ` Anthony Liguori
2012-08-02 18:05 ` Luiz Capitulino [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120802150520.049c3261@doriath.home \
--to=lcapitulino@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=armbru@redhat.com \
--cc=avi@redhat.com \
--cc=eblake@redhat.com \
--cc=jbaron@redhat.com \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).