From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:38074)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1SwzlT-00046p-3K
	for qemu-devel@nongnu.org; Thu, 02 Aug 2012 14:04:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1SwzlO-0007KI-Sq
	for qemu-devel@nongnu.org; Thu, 02 Aug 2012 14:04:51 -0400
Received: from mx1.redhat.com ([209.132.183.28]:9380)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1SwzlO-0007KC-Jx
	for qemu-devel@nongnu.org; Thu, 02 Aug 2012 14:04:46 -0400
Date: Thu, 2 Aug 2012 15:05:20 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20120802150520.049c3261@doriath.home>
In-Reply-To: <877gti8oca.fsf@codemonkey.ws>
References: <201208011619.q71GJSqg017150@int-mx01.intmail.prod.int.phx2.redhat.com>
	<877gti8oca.fsf@codemonkey.ws>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] memory: add cmd line option,
 to omit guest memory from qemu core dump
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Jason Baron <jbaron@redhat.com>, mtosatti@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, avi@redhat.com, eblake@redhat.com

On Wed, 01 Aug 2012 13:21:57 -0500
Anthony Liguori <anthony@codemonkey.ws> wrote:

> > diff --git a/qemu-config.c b/qemu-config.c
> > index 5c3296b..5c2c9a9 100644
> > --- a/qemu-config.c
> > +++ b/qemu-config.c
> > @@ -595,6 +595,10 @@ static QemuOptsList qemu_machine_opts = {
> >              .name = "dt_compatible",
> >              .type = QEMU_OPT_STRING,
> >              .help = "Overrides the \"compatible\" property of the dt root node",
> > +        }, {
> > +            .name = "dump_guest_core",
> 
> "dump-guest-core"

Without your patch to accept both "-" and "_", this will be inconsistent
with the other options.

It's not like I mind too much, but then my patch adding mem-merge could
also be applied (Jan objected because of -/_ mixture).