From: Luiz Capitulino <lcapitulino@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 3/6] qapi: avoid reserved keywords
Date: Thu, 2 Aug 2012 17:52:49 -0300 [thread overview]
Message-ID: <20120802175249.1a1567cc@doriath.home> (raw)
In-Reply-To: <87ehnphex0.fsf@blackfin.pond.sub.org>
On Thu, 02 Aug 2012 10:32:59 +0200
Markus Armbruster <armbru@redhat.com> wrote:
> Blue Swirl <blauwirbel@gmail.com> writes:
>
> > Clang compiler complained about use of reserved word 'restrict' in SLIRP
> > and QAPI.
> >
> > Prefix C keywords with "q_", adjust SLIRP accordingly.
> >
> > Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
>
> I like this solution.
Yeah, looks good.
Would be nice to add a note to docs/writing-qmp-commands.txt (can be in an
incremental patch).
>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
>
next prev parent reply other threads:[~2012-08-02 20:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-01 18:21 [Qemu-devel] [PATCH v2 0/6] Clang patches Blue Swirl
2012-08-01 18:21 ` [Qemu-devel] [PATCH v2 1/6] sparc: fix floppy TC line setup Blue Swirl
2012-08-01 18:21 ` [Qemu-devel] [PATCH v2 2/6] sparc: fix expression with uninitialized initial value Blue Swirl
2012-08-01 18:21 ` [Qemu-devel] [PATCH v2 3/6] qapi: avoid reserved keywords Blue Swirl
2012-08-02 8:32 ` Markus Armbruster
2012-08-02 20:52 ` Luiz Capitulino [this message]
2012-08-01 18:21 ` [Qemu-devel] [PATCH v2 4/6] user: fix accidental AREG0 use Blue Swirl
2012-08-01 18:21 ` [Qemu-devel] [PATCH v2 5/6] xilinx_axienet: avoid useless self-assignment Blue Swirl
2012-08-01 18:21 ` [Qemu-devel] [PATCH v2 6/6] scsi-bus: remove overlapping entry Blue Swirl
2012-08-02 8:30 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120802175249.1a1567cc@doriath.home \
--to=lcapitulino@redhat.com \
--cc=armbru@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).