From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36896) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sx2NS-00039U-JV for qemu-devel@nongnu.org; Thu, 02 Aug 2012 16:52:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sx2NR-0000PT-Nj for qemu-devel@nongnu.org; Thu, 02 Aug 2012 16:52:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:64032) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sx2NR-0000PM-F1 for qemu-devel@nongnu.org; Thu, 02 Aug 2012 16:52:13 -0400 Date: Thu, 2 Aug 2012 17:52:49 -0300 From: Luiz Capitulino Message-ID: <20120802175249.1a1567cc@doriath.home> In-Reply-To: <87ehnphex0.fsf@blackfin.pond.sub.org> References: <5b7f43cadcf27396ce5b40f7505a08cc36b2e6cd.1343845033.git.blauwirbel@gmail.com> <87ehnphex0.fsf@blackfin.pond.sub.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 3/6] qapi: avoid reserved keywords List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Blue Swirl , qemu-devel@nongnu.org On Thu, 02 Aug 2012 10:32:59 +0200 Markus Armbruster wrote: > Blue Swirl writes: > > > Clang compiler complained about use of reserved word 'restrict' in SLIRP > > and QAPI. > > > > Prefix C keywords with "q_", adjust SLIRP accordingly. > > > > Signed-off-by: Blue Swirl > > I like this solution. Yeah, looks good. Would be nice to add a note to docs/writing-qmp-commands.txt (can be in an incremental patch). > > Reviewed-by: Markus Armbruster >