From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51021) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SxHN5-0003Fj-AM for qemu-devel@nongnu.org; Fri, 03 Aug 2012 08:52:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SxHMy-0006mg-Db for qemu-devel@nongnu.org; Fri, 03 Aug 2012 08:52:51 -0400 Date: Fri, 3 Aug 2012 09:53:18 -0300 From: Luiz Capitulino Message-ID: <20120803095318.44ae5920@doriath.home> In-Reply-To: <1343963182-28297-2-git-send-email-akong@redhat.com> References: <1343963182-28297-1-git-send-email-akong@redhat.com> <1343963182-28297-2-git-send-email-akong@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1/2] remove unused include of error.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amos Kong Cc: qemu-trivial@nongnu.org, stefanha@gmail.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, quintela@redhat.com On Fri, 3 Aug 2012 11:06:21 +0800 Amos Kong wrote: > Signed-off-by: Amos Kong > --- > qemu_socket.h | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/qemu_socket.h b/qemu_socket.h > index 4689ff3..1a2f517 100644 > --- a/qemu_socket.h > +++ b/qemu_socket.h > @@ -27,7 +27,6 @@ int inet_aton(const char *cp, struct in_addr *ia); > #endif /* !_WIN32 */ > > #include "qemu-option.h" > -#include "error.h" > #include "qerror.h" This is wrong. There are functions in this header that takes an Error argument (which is declared in error.h). qerror.h should be dropped though, as it's deprecated and as such shouldn't be in a public header like this. If you get build failures, then you can include it in the .c files where it's missing. > > /* misc helpers */