From: Stefan Hajnoczi <stefanha@gmail.com>
To: Tyler Hall <tylerwhall@gmail.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/2] exec.c: Fix off-by-one error in register_subpage
Date: Fri, 3 Aug 2012 10:55:15 +0100 [thread overview]
Message-ID: <20120803095515.GA23797@stefanha-thinkpad.localdomain> (raw)
In-Reply-To: <1343256304-32029-1-git-send-email-tylerwhall@gmail.com>
On Wed, Jul 25, 2012 at 06:45:03PM -0400, Tyler Hall wrote:
> subpage_register() expects "end" to be the last byte in the mapping.
> Registering a non-page-aligned memory region that extends up to or
> beyond a page boundary causes subpage_register() to silently fail
> through the (end >= PAGE_SIZE) check.
>
> This bug does not cause noticeable problems for mappings that do not
> extend to a page boundary, though they do register an extra byte.
>
> Signed-off-by: Tyler Hall <tylerwhall@gmail.com>
> ---
> exec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, both applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan
prev parent reply other threads:[~2012-08-03 9:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-25 22:45 [Qemu-devel] [PATCH 1/2] exec.c: Fix off-by-one error in register_subpage Tyler Hall
2012-07-25 22:45 ` [Qemu-devel] [PATCH 2/2] exec.c: Use subpages for large unaligned mappings Tyler Hall
2012-08-01 13:02 ` Avi Kivity
2012-08-01 10:42 ` [Qemu-devel] [Qemu-trivial] [PATCH 1/2] exec.c: Fix off-by-one error in register_subpage Stefan Hajnoczi
2012-08-01 12:52 ` Peter Maydell
2012-08-01 12:56 ` [Qemu-devel] " Avi Kivity
2012-08-01 13:01 ` Stefan Hajnoczi
2012-08-01 13:03 ` Avi Kivity
2012-08-03 9:55 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120803095515.GA23797@stefanha-thinkpad.localdomain \
--to=stefanha@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=tylerwhall@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).