From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57326) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SxEbM-0006XN-G6 for qemu-devel@nongnu.org; Fri, 03 Aug 2012 05:55:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SxEbI-0006SX-EY for qemu-devel@nongnu.org; Fri, 03 Aug 2012 05:55:24 -0400 Date: Fri, 3 Aug 2012 10:55:15 +0100 From: Stefan Hajnoczi Message-ID: <20120803095515.GA23797@stefanha-thinkpad.localdomain> References: <1343256304-32029-1-git-send-email-tylerwhall@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1343256304-32029-1-git-send-email-tylerwhall@gmail.com> Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/2] exec.c: Fix off-by-one error in register_subpage List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Tyler Hall Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org On Wed, Jul 25, 2012 at 06:45:03PM -0400, Tyler Hall wrote: > subpage_register() expects "end" to be the last byte in the mapping. > Registering a non-page-aligned memory region that extends up to or > beyond a page boundary causes subpage_register() to silently fail > through the (end >= PAGE_SIZE) check. > > This bug does not cause noticeable problems for mappings that do not > extend to a page boundary, though they do register an extra byte. > > Signed-off-by: Tyler Hall > --- > exec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, both applied to the trivial patches tree: https://github.com/stefanha/qemu/commits/trivial-patches Stefan