From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57472) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SxEcI-0007Xi-Fb for qemu-devel@nongnu.org; Fri, 03 Aug 2012 05:56:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SxEcE-0006tE-F9 for qemu-devel@nongnu.org; Fri, 03 Aug 2012 05:56:22 -0400 Date: Fri, 3 Aug 2012 10:56:14 +0100 From: Stefan Hajnoczi Message-ID: <20120803095614.GB23797@stefanha-thinkpad.localdomain> References: <1343828147-9446-1-git-send-email-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1343828147-9446-1-git-send-email-peter.maydell@linaro.org> Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] exec.c: Remove out of date comment List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-trivial@nongnu.org, patches@linaro.org, qemu-devel@nongnu.org, Avi Kivity On Wed, Aug 01, 2012 at 02:35:47PM +0100, Peter Maydell wrote: > Remove an out of date comment: this comment used to be attached to > cpu_register_physical_memory_log(), before commit 0f0cb164 accidentally > inserted a couple of other functions between the comment and its function. > It is in any case obsolete since (a) the function arguments it refers > to have been replaced with a single MemoryRegionSection* argument and > (b) the inability to handle regions whose offset_within_address_space > and offset_within_region aren't equally aligned was fixed as part of > the rewrite of this code. > > Signed-off-by: Peter Maydell > --- > Pretty sure my analysis is right and this comment is out of date -- > Avi, could you confirm that please? > > exec.c | 8 -------- > 1 file changed, 8 deletions(-) Thanks, applied to the trivial patches tree: https://github.com/stefanha/qemu/commits/trivial-patches Stefan