From: Luiz Capitulino <lcapitulino@redhat.com>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Amos Kong <akong@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/7] remove unused include of error.h
Date: Fri, 3 Aug 2012 10:00:58 -0300 [thread overview]
Message-ID: <20120803100058.03948f71@doriath.home> (raw)
In-Reply-To: <1343991066-9814-4-git-send-email-stefanha@linux.vnet.ibm.com>
On Fri, 3 Aug 2012 11:51:02 +0100
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com> wrote:
> From: Amos Kong <akong@redhat.com>
>
> Signed-off-by: Amos Kong <akong@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
> ---
> qemu_socket.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/qemu_socket.h b/qemu_socket.h
> index 4689ff3..1a2f517 100644
> --- a/qemu_socket.h
> +++ b/qemu_socket.h
> @@ -27,7 +27,6 @@ int inet_aton(const char *cp, struct in_addr *ia);
> #endif /* !_WIN32 */
>
> #include "qemu-option.h"
> -#include "error.h"
> #include "qerror.h"
nack on this one, as it's dropping the wrong file.
qemu_socket.h declares functions that take an Error argument, so it has
to include error.h.
However, qerror.h should be dropped and any build breakage should be
fixed by including qerror.h in the .c files it's missing.
>
> /* misc helpers */
next prev parent reply other threads:[~2012-08-03 13:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-03 10:50 [Qemu-devel] [PULL 0/7] Trivial patches for 22 July to 3 August 2012 Stefan Hajnoczi
2012-08-03 10:51 ` [Qemu-devel] [PATCH 1/7] usb: Clean common object and dependency files Stefan Hajnoczi
2012-08-03 10:51 ` [Qemu-devel] [PATCH 2/7] qom: Clean libuser " Stefan Hajnoczi
2012-08-03 10:51 ` [Qemu-devel] [PATCH 3/7] remove unused include of error.h Stefan Hajnoczi
2012-08-03 13:00 ` Luiz Capitulino [this message]
2012-08-03 13:24 ` Stefan Hajnoczi
2012-08-03 10:51 ` [Qemu-devel] [PATCH 4/7] socket: clean up redundant assignment Stefan Hajnoczi
2012-08-03 10:51 ` [Qemu-devel] [PATCH 5/7] exec.c: Fix off-by-one error in register_subpage Stefan Hajnoczi
2012-08-03 10:51 ` [Qemu-devel] [PATCH 6/7] exec.c: Use subpages for large unaligned mappings Stefan Hajnoczi
2012-08-03 10:51 ` [Qemu-devel] [PATCH 7/7] exec.c: Remove out of date comment Stefan Hajnoczi
2012-08-03 13:27 ` [Qemu-devel] [PULL 0/7] Trivial patches for 22 July to 3 August 2012 Stefan Hajnoczi
2012-08-03 20:43 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120803100058.03948f71@doriath.home \
--to=lcapitulino@redhat.com \
--cc=akong@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).