From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57247) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SxHUa-0006sm-9k for qemu-devel@nongnu.org; Fri, 03 Aug 2012 09:00:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SxHUQ-0000pe-SH for qemu-devel@nongnu.org; Fri, 03 Aug 2012 09:00:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:24726) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SxHUQ-0000pT-KX for qemu-devel@nongnu.org; Fri, 03 Aug 2012 09:00:26 -0400 Date: Fri, 3 Aug 2012 10:00:58 -0300 From: Luiz Capitulino Message-ID: <20120803100058.03948f71@doriath.home> In-Reply-To: <1343991066-9814-4-git-send-email-stefanha@linux.vnet.ibm.com> References: <1343991066-9814-1-git-send-email-stefanha@linux.vnet.ibm.com> <1343991066-9814-4-git-send-email-stefanha@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/7] remove unused include of error.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Anthony Liguori , Amos Kong , qemu-devel@nongnu.org On Fri, 3 Aug 2012 11:51:02 +0100 Stefan Hajnoczi wrote: > From: Amos Kong > > Signed-off-by: Amos Kong > Signed-off-by: Stefan Hajnoczi > --- > qemu_socket.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/qemu_socket.h b/qemu_socket.h > index 4689ff3..1a2f517 100644 > --- a/qemu_socket.h > +++ b/qemu_socket.h > @@ -27,7 +27,6 @@ int inet_aton(const char *cp, struct in_addr *ia); > #endif /* !_WIN32 */ > > #include "qemu-option.h" > -#include "error.h" > #include "qerror.h" nack on this one, as it's dropping the wrong file. qemu_socket.h declares functions that take an Error argument, so it has to include error.h. However, qerror.h should be dropped and any build breakage should be fixed by including qerror.h in the .c files it's missing. > > /* misc helpers */