From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:35420)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1SxOWv-0007zJ-Q1
	for qemu-devel@nongnu.org; Fri, 03 Aug 2012 16:31:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1SxOWu-0005aZ-Qz
	for qemu-devel@nongnu.org; Fri, 03 Aug 2012 16:31:29 -0400
Received: from mx1.redhat.com ([209.132.183.28]:65102)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1SxOWu-0005aT-Iz
	for qemu-devel@nongnu.org; Fri, 03 Aug 2012 16:31:28 -0400
Date: Fri, 3 Aug 2012 17:32:04 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20120803173204.49652093@doriath.home>
In-Reply-To: <501C11CF.3050907@suse.de>
References: <1343962122-26696-1-git-send-email-akong@redhat.com>
	<1343962122-26696-6-git-send-email-akong@redhat.com>
	<20120803103233.2f48d5d1@doriath.home> <501C11CF.3050907@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v6 5/7] add the QKeyCode enum and the
 key_defs table
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?ISO-8859-1?B?RuRyYmVy?= <afaerber@suse.de>
Cc: aliguori@us.ibm.com, Amos Kong <akong@redhat.com>, eblake@redhat.com, qemu-devel@nongnu.org

On Fri, 03 Aug 2012 20:00:47 +0200
Andreas F=E4rber <afaerber@suse.de> wrote:

> Am 03.08.2012 15:32, schrieb Luiz Capitulino:
> > On Fri,  3 Aug 2012 10:48:40 +0800
> > Amos Kong <akong@redhat.com> wrote:
> >=20
> >> key_defs[] in monitor.c is a mapping table of keys and keycodes,
> >> this patch added a QKeyCode enum and a new key_defs table,
> >> Key's index in the enmu is same as keycode's index in new key_defs[].
> >>
> >> Signed-off-by: Amos Kong <akong@redhat.com>
> >> ---
> >>  input.c          |  146 +++++++++++++++++++++++++++++++++++++++++++++=
+++++++++
> >>  qapi-schema.json |   26 ++++++++++
> >>  2 files changed, 172 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/input.c b/input.c
> >> index 6968b31..680d756 100644
> >> --- a/input.c
> >> +++ b/input.c
> >> @@ -37,6 +37,152 @@ static QTAILQ_HEAD(, QEMUPutMouseEntry) mouse_hand=
lers =3D
> >>  static NotifierList mouse_mode_notifiers =3D=20
> >>      NOTIFIER_LIST_INITIALIZER(mouse_mode_notifiers);
> >> =20
> >> +static const int key_defs[] =3D {
> >=20
> > Weird, I expected this would brake the build, as the new table is unuse=
d.
>=20
> That's a side effect of 'const'.

Good to know, thanks.

>=20
> /-F
>=20