From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56425) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyMw2-0004eS-4o for qemu-devel@nongnu.org; Mon, 06 Aug 2012 09:01:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SyMvs-0006AU-OR for qemu-devel@nongnu.org; Mon, 06 Aug 2012 09:01:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52338) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyMvs-0006AK-G8 for qemu-devel@nongnu.org; Mon, 06 Aug 2012 09:01:16 -0400 Date: Mon, 6 Aug 2012 10:01:50 -0300 From: Luiz Capitulino Message-ID: <20120806100150.426a5512@doriath.home> In-Reply-To: <637142518.186598.1344234903791.JavaMail.root@redhat.com> References: <20120802103146.17d732e9@doriath.home> <637142518.186598.1344234903791.JavaMail.root@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC 00/27]: add new error format List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amos Kong Cc: kwolf@redhat.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, armbru@redhat.com, pbonzini@redhat.com, eblake@redhat.com On Mon, 6 Aug 2012 02:35:03 -0400 (EDT) Amos Kong wrote: > ----- Original Message ----- > > On Thu, 02 Aug 2012 10:31:28 +0800 > > Amos Kong wrote: > > > > > On 01/08/12 21:29, Luiz Capitulino wrote: > > > > On Wed, 01 Aug 2012 19:33:27 +0800 > > > > Amos Kong wrote: > > > > > > > >> On 31/07/12 22:44, Luiz Capitulino wrote: > > > >>> On Fri, 27 Jul 2012 18:31:41 -0300 > > > >>> Luiz Capitulino wrote: > > > >>> > > > >>>> [Please, read below why this is an RFC] > > > >>>> > > > >>>> This series implements the 'Plan for error handling in QMP' as > > > >>>> described > > > >>>> by Anthony in this email: > > > >> > > > >> > > > >> > > > >> Tested with > > > >> http://repo.or.cz/w/qemu/qmp-unstable.git/shortlog/refs/heads/error/new-format/v1 > > > > > > > > Thanks for testing Amos, but that branch is where I'm working > > > > currently so > > > > the code there is constantly changing. It's better to wait until > > > > I post it > > > > to the list. > > > > > > Got it. > > > > > > > Could you share your test-case, btw? > > > > > > 1. start a migration listen vm > > > x86_64-softmmu/qemu-system-x86_64 -monitor stdio -boot n -vnc :2 > > > -incoming tcp:0:1234 > > > > > > 2. start a migration client vm > > > x86_64-softmmu/qemu-system-x86_64 --enable-kvm -monitor stdio -boot > > > n > > > -vnc :1 > > > > > > 3. execute migration > > > vm2 (qemu) migrate -d tcp:0:1234 > > > vm2 (qemu) info migration > > > > > > expected result: migration should complete successfully > > > > This should work fine with v1 I posted yesterday. > > > > Actually, master is buggy: > > > > (qemu) migrate -d tcp:0:4444 > > migrate: Connection can not be completed immediately > > > I thought it's a note of real socket status, not an error message. That's not something relevant for the user to know because it's temporary, and the user can't do anything about it anyway. > > > > (qemu) > > > > I wonder how you did not get this on your test-case? > > > Anyway, this is also fixed in v1. > > Thanks. > >