From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53326) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SzNx0-0000a8-Vl for qemu-devel@nongnu.org; Thu, 09 Aug 2012 04:18:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SzNww-0006Tj-Up for qemu-devel@nongnu.org; Thu, 09 Aug 2012 04:18:38 -0400 Received: from e23smtp06.au.ibm.com ([202.81.31.148]:40962) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SzNww-0006Ta-Ah for qemu-devel@nongnu.org; Thu, 09 Aug 2012 04:18:34 -0400 Received: from /spool/local by e23smtp06.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 9 Aug 2012 18:17:57 +1000 Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139]) by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q7989qvP11796618 for ; Thu, 9 Aug 2012 18:09:55 +1000 Received: from d23av04.au.ibm.com (loopback [127.0.0.1]) by d23av04.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q798IIS0027012 for ; Thu, 9 Aug 2012 18:18:18 +1000 Date: Thu, 9 Aug 2012 13:49:51 +0530 From: Bharata B Rao Message-ID: <20120809081951.GA18244@in.ibm.com> References: <20120807075928.GB7480@in.ibm.com> <20120807080026.GC7480@in.ibm.com> <50229180.8060705@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50229180.8060705@redhat.com> Subject: Re: [Qemu-devel] [PATCH v5 1/2] qemu: Add a config option for GlusterFS as block backend Reply-To: bharata@linux.vnet.ibm.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anand Avati Cc: Kevin Wolf , Anthony Liguori , Stefan Hajnoczi , Vijay Bellur , Amar Tumballi , qemu-devel@nongnu.org, Blue Swirl , Paolo Bonzini On Wed, Aug 08, 2012 at 09:19:12AM -0700, Anand Avati wrote: > > It would be best if the autoconf changes is based on pkgconfig as > shown in https://github.com/gluster/glusterfs/blob/master/api/examples/configure.ac. > If you do not want to introduce pkgconfig dependency (if you already > do not have it) then it would be good to adopt the steps mentioned > in section "2." of > https://github.com/gluster/glusterfs/blob/master/api/examples/README. > That would basically mean including "-I/path/include/glusterfs" in > CPPFLAGS and only "#include " instead of > . I don't see others in QEMU doing this currently. I suggest that we have the current patchset in 1.2 and see if such improvements can be done subsequently. Regards, Bharata.