From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45280) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SzN2O-0007cY-9I for qemu-devel@nongnu.org; Thu, 09 Aug 2012 03:20:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SzN2N-0005td-4E for qemu-devel@nongnu.org; Thu, 09 Aug 2012 03:20:08 -0400 Received: from e06smtp11.uk.ibm.com ([195.75.94.107]:49086) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SzN2M-0005nH-S2 for qemu-devel@nongnu.org; Thu, 09 Aug 2012 03:20:07 -0400 Received: from /spool/local by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 9 Aug 2012 08:20:04 +0100 Received: from d06av07.portsmouth.uk.ibm.com (d06av07.portsmouth.uk.ibm.com [9.149.37.248]) by b06cxnps3075.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q797Jthf21168158 for ; Thu, 9 Aug 2012 07:19:55 GMT Received: from d06av07.portsmouth.uk.ibm.com (d06av07.portsmouth.uk.ibm.com [127.0.0.1]) by d06av07.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q796uD2O025462 for ; Thu, 9 Aug 2012 02:56:13 -0400 Date: Thu, 9 Aug 2012 09:19:58 +0200 From: Cornelia Huck Message-ID: <20120809091958.771eb7ed@BR9GNB5Z> In-Reply-To: References: <1344351173-2716-1-git-send-email-cornelia.huck@de.ibm.com> <1344351173-2716-3-git-send-email-cornelia.huck@de.ibm.com> <20120808101750.35800579@BR9GNB5Z> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/5] s390: Virtual channel subsystem support. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: Peter Maydell , Anthony Liguori , Rusty Russell , KVM , Carsten Otte , linux-s390 , Marcelo Tosatti , Heiko Carstens , qemu-devel , Alexander Graf , Christian Borntraeger , Avi Kivity , Sebastian Ott , Martin Schwidefsky On Wed, 8 Aug 2012 19:39:33 +0000 Blue Swirl wrote: > On Wed, Aug 8, 2012 at 7:34 PM, Peter Maydell wrote: > > On 8 August 2012 20:16, Blue Swirl wrote: > >> On Wed, Aug 8, 2012 at 8:17 AM, Cornelia Huck wrote: > >>> On Tue, 7 Aug 2012 21:00:59 +0000 > >>> Blue Swirl wrote: > >>>> Please use more descriptive names instead of acronyms, for example SubChStatus. > >>> > >>> I'd rather leave these at the well-known scsw, pmcw, etc. names. These > >>> have been around for decades, and somebody familiar with channel I/O > >>> will instantly know what a struct scsw is, but will need to look hard > >>> at the code to figure out the meaning of SubChStatus. > >> > >> If they are well-known and have been around for so long time, are > >> there any suitable header files (with compatible licenses) where they > >> are defined which could be reused? There's the Linux headers, but they are not exported as this is not a user space interface (on the guest side). Otherwise, most code dealing with channel I/O is probably not written in C ;) > >> > >> Otherwise, please follow CODING_STYLE. > > > > I think we should follow CODING_STYLE for capitalisation issues > > but generally if the device's documentation has standard abbreviations > > for register names, structures, etc, etc we should use them. Often > > this code has to be maintained later by somebody else who might not > > be familiar with the general operation of the hardware and who is trying > > to match up the code with whatever the data sheet says. Following the > > naming used in the h/w docs makes that job easier. > > Yes. typedef struct SCSW {} SCSW; should be OK too. Then I'll use something like that.