From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: linux-s390 <linux-s390@vger.kernel.org>,
Anthony Liguori <aliguori@us.ibm.com>,
Marcelo Tosatti <mtosatti@redhat.com>, KVM <kvm@vger.kernel.org>,
Carsten Otte <cotte@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Rusty Russell <rusty@rustcorp.com.au>,
Sebastian Ott <sebott@linux.vnet.ibm.com>,
qemu-devel <qemu-devel@nongnu.org>,
Alexander Graf <agraf@suse.de>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Avi Kivity <avi@redhat.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 3/5] s390: Add new channel I/O based virtio transport.
Date: Thu, 9 Aug 2012 09:21:03 +0200 [thread overview]
Message-ID: <20120809092103.4317b357@BR9GNB5Z> (raw)
In-Reply-To: <CAAu8pHsOiAgGGu8101CAm31goVMjO3d=1Oh1m4PAq6xTqhfpGQ@mail.gmail.com>
On Wed, 8 Aug 2012 19:03:14 +0000
Blue Swirl <blauwirbel@gmail.com> wrote:
> >> > +struct vq_info_block {
> >> > + uint64_t queue;
> >> > + uint16_t num;
> >> > +} QEMU_PACKED;
> >> > +
> >> > +struct vq_config_block {
> >> > + uint16_t index;
> >> > + uint16_t num;
> >> > +} QEMU_PACKED;
> >>
> >> Aren't these KVM structures? They should be defined in a KVM header
> >> file file in linux-headers.
> >
> > Not really, virtio-ccw isn't tied to kvm.
> >
> > I see this more as command blocks that are specific to the "control
> > unit" - like something that would be defined in an attachment
> > specification for a classic s390 device (and in the virtio spec in this
> > case) and modeled as C structures here.
>
> OK. Then please use CamelCase for these too.
>
OK.
next prev parent reply other threads:[~2012-08-09 7:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-07 14:52 [Qemu-devel] [RFC PATCH 0/5] qemu: s390: virtual css and virtio-ccw Cornelia Huck
2012-08-07 14:52 ` [Qemu-devel] [PATCH 1/5] Update headers for upcoming s390 changes Cornelia Huck
2012-08-07 14:52 ` [Qemu-devel] [PATCH 2/5] s390: Virtual channel subsystem support Cornelia Huck
2012-08-07 21:00 ` Blue Swirl
2012-08-08 8:17 ` Cornelia Huck
2012-08-08 19:16 ` Blue Swirl
2012-08-08 19:34 ` Peter Maydell
2012-08-08 19:39 ` Blue Swirl
2012-08-09 7:19 ` Cornelia Huck
2012-08-08 8:27 ` Peter Maydell
2012-08-08 8:53 ` Cornelia Huck
2012-08-07 14:52 ` [Qemu-devel] [PATCH 3/5] s390: Add new channel I/O based virtio transport Cornelia Huck
2012-08-07 20:47 ` Blue Swirl
2012-08-08 8:28 ` Cornelia Huck
2012-08-08 19:03 ` Blue Swirl
2012-08-09 7:21 ` Cornelia Huck [this message]
2012-08-09 11:34 ` Stefan Hajnoczi
2012-08-09 12:12 ` Cornelia Huck
2012-08-09 12:27 ` Stefan Hajnoczi
2012-08-07 14:52 ` [Qemu-devel] [PATCH 4/5] s390: Virtual channel subsystem support for !KVM Cornelia Huck
2012-08-07 14:52 ` [Qemu-devel] [PATCH 5/5] [HACK] Handle multiple virtio aliases Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120809092103.4317b357@BR9GNB5Z \
--to=cornelia.huck@de.ibm.com \
--cc=agraf@suse.de \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=borntraeger@de.ibm.com \
--cc=cotte@de.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rusty@rustcorp.com.au \
--cc=schwidefsky@de.ibm.com \
--cc=sebott@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).