From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:45662)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1SzN3V-0000Sa-GI
	for qemu-devel@nongnu.org; Thu, 09 Aug 2012 03:21:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1SzN3U-0006bS-8v
	for qemu-devel@nongnu.org; Thu, 09 Aug 2012 03:21:17 -0400
Received: from e06smtp11.uk.ibm.com ([195.75.94.107]:49279)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1SzN3T-0006Zo-U4
	for qemu-devel@nongnu.org; Thu, 09 Aug 2012 03:21:16 -0400
Received: from /spool/local
	by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <cornelia.huck@de.ibm.com>;
	Thu, 9 Aug 2012 08:21:15 +0100
Received: from d06av06.portsmouth.uk.ibm.com (d06av06.portsmouth.uk.ibm.com
	[9.149.37.217])
	by b06cxnps3074.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with
	ESMTP id q797L0kX40173776
	for <qemu-devel@nongnu.org>; Thu, 9 Aug 2012 07:21:00 GMT
Received: from d06av06.portsmouth.uk.ibm.com (loopback [127.0.0.1])
	by d06av06.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with
	ESMTP id q797L5uI022574
	for <qemu-devel@nongnu.org>; Thu, 9 Aug 2012 01:21:06 -0600
Date: Thu, 9 Aug 2012 09:21:03 +0200
From: Cornelia Huck <cornelia.huck@de.ibm.com>
Message-ID: <20120809092103.4317b357@BR9GNB5Z>
In-Reply-To: <CAAu8pHsOiAgGGu8101CAm31goVMjO3d=1Oh1m4PAq6xTqhfpGQ@mail.gmail.com>
References: <1344351173-2716-1-git-send-email-cornelia.huck@de.ibm.com>
	<1344351173-2716-4-git-send-email-cornelia.huck@de.ibm.com>
	<CAAu8pHvt+17+EF=k7ZOx1bKpO=33PVXfBNQJWzNpYmqKkhR1ZQ@mail.gmail.com>
	<20120808102820.799d3d9a@BR9GNB5Z>
	<CAAu8pHsOiAgGGu8101CAm31goVMjO3d=1Oh1m4PAq6xTqhfpGQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/5] s390: Add new channel I/O based virtio
 transport.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: linux-s390 <linux-s390@vger.kernel.org>, Anthony Liguori <aliguori@us.ibm.com>, Marcelo Tosatti <mtosatti@redhat.com>, KVM <kvm@vger.kernel.org>, Carsten Otte <cotte@de.ibm.com>, Heiko Carstens <heiko.carstens@de.ibm.com>, Rusty Russell <rusty@rustcorp.com.au>, Sebastian Ott <sebott@linux.vnet.ibm.com>, qemu-devel <qemu-devel@nongnu.org>, Alexander Graf <agraf@suse.de>, Christian Borntraeger <borntraeger@de.ibm.com>, Avi Kivity <avi@redhat.com>, Martin Schwidefsky <schwidefsky@de.ibm.com>

On Wed, 8 Aug 2012 19:03:14 +0000
Blue Swirl <blauwirbel@gmail.com> wrote:


> >> > +struct vq_info_block {
> >> > +    uint64_t queue;
> >> > +    uint16_t num;
> >> > +} QEMU_PACKED;
> >> > +
> >> > +struct vq_config_block {
> >> > +    uint16_t index;
> >> > +    uint16_t num;
> >> > +} QEMU_PACKED;
> >>
> >> Aren't these KVM structures? They should be defined in a KVM header
> >> file file in linux-headers.
> >
> > Not really, virtio-ccw isn't tied to kvm.
> >
> > I see this more as command blocks that are specific to the "control
> > unit" - like something that would be defined in an attachment
> > specification for a classic s390 device (and in the virtio spec in this
> > case) and modeled as C structures here.
> 
> OK. Then please use CamelCase for these too.
> 

OK.