From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:55786)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1SzSzs-0003gx-5e
	for qemu-devel@nongnu.org; Thu, 09 Aug 2012 09:42:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1SzSzq-00053G-QP
	for qemu-devel@nongnu.org; Thu, 09 Aug 2012 09:41:56 -0400
Received: from mx1.redhat.com ([209.132.183.28]:58519)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1SzSzq-00051x-IN
	for qemu-devel@nongnu.org; Thu, 09 Aug 2012 09:41:54 -0400
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q79DfViA001434
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 9 Aug 2012 09:41:31 -0400
Date: Thu, 9 Aug 2012 16:41:22 +0300
From: Alon Levy <alevy@redhat.com>
Message-ID: <20120809134122.GB6680@garlic.redhat.com>
References: <CAAu8pHtqYEQ7WruVAVcpaZDRdx0sO3182wcofmqPuOGBtf5+2A@mail.gmail.com>
	<1343471002-14640-1-git-send-email-alevy@redhat.com>
	<501F72C7.5040607@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <501F72C7.5040607@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: yhalperi@redhat.com, qemu-devel@nongnu.org

On Mon, Aug 06, 2012 at 09:31:19AM +0200, Gerd Hoffmann wrote:
> > diff --git a/configure b/configure
> > index cef0a71..5fcd315 100755
> > --- a/configure
> > +++ b/configure
> > @@ -2630,7 +2630,7 @@ EOF
> >    spice_cflags=$($pkg_config --cflags spice-protocol spice-server 2>/dev/null)
> >    spice_libs=$($pkg_config --libs spice-protocol spice-server 2>/dev/null)
> >    if $pkg_config --atleast-version=0.8.2 spice-server >/dev/null 2>&1 && \
> > -     $pkg_config --atleast-version=0.8.1 spice-protocol > /dev/null 2>&1 && \
> > +     $pkg_config --atleast-version=0.12.0 spice-protocol > /dev/null 2>&1 && \
> 
> I'd prefer to not require cutting-edge spice bits to build ...

I only increased the protocol requirement, not the server.

This is actually not related to the SERVER_VERSION below, it's needed
for the new io code QXL_IO_MONITORS_CONFIG_ASYNC. I would like to
propose we add spice-protocol as a submodule to fix this dependency,
since it's a small module containing headers, so even if it isn't used
it shouldn't place a large burden on qemu developers.

Meanwhile I'll add a define based on the pkg-config spice-protocol
version, which I can test from hw/qxl.c, since the commit adding
QXL_IO_MONITORS_CONFIG_ASYNC didn't introduce any new define I can
check.

> 
> >      case QXL_IO_FLUSH_SURFACES_ASYNC:
> > +#if SPICE_SERVER_VERSION >= 0x000b01 /* 0.11.1 */
> > +    case QXL_IO_MONITORS_CONFIG_ASYNC:
> > +#endif
> 
> ... and given you #ifdef the new stuff anyway it should not be needed.
> 
> cheers,
>   Gerd
>