From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57387) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SzTZC-0004L2-FC for qemu-devel@nongnu.org; Thu, 09 Aug 2012 10:18:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SzTZB-0000Tg-Ek for qemu-devel@nongnu.org; Thu, 09 Aug 2012 10:18:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:17124) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SzTZB-0000TR-5W for qemu-devel@nongnu.org; Thu, 09 Aug 2012 10:18:25 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q79EIOKA013758 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 9 Aug 2012 10:18:24 -0400 Date: Thu, 9 Aug 2012 17:18:15 +0300 From: Alon Levy Message-ID: <20120809141815.GC6680@garlic.redhat.com> References: <1343471002-14640-1-git-send-email-alevy@redhat.com> <501F72C7.5040607@redhat.com> <20120809134122.GB6680@garlic.redhat.com> <5023C014.2080407@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5023C014.2080407@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: yhalperi@redhat.com, qemu-devel@nongnu.org On Thu, Aug 09, 2012 at 03:50:12PM +0200, Gerd Hoffmann wrote: > On 08/09/12 15:41, Alon Levy wrote: > > On Mon, Aug 06, 2012 at 09:31:19AM +0200, Gerd Hoffmann wrote: > >>> diff --git a/configure b/configure > >>> index cef0a71..5fcd315 100755 > >>> --- a/configure > >>> +++ b/configure > >>> @@ -2630,7 +2630,7 @@ EOF > >>> spice_cflags=$($pkg_config --cflags spice-protocol spice-server 2>/dev/null) > >>> spice_libs=$($pkg_config --libs spice-protocol spice-server 2>/dev/null) > >>> if $pkg_config --atleast-version=0.8.2 spice-server >/dev/null 2>&1 && \ > >>> - $pkg_config --atleast-version=0.8.1 spice-protocol > /dev/null 2>&1 && \ > >>> + $pkg_config --atleast-version=0.12.0 spice-protocol > /dev/null 2>&1 && \ > >> > >> I'd prefer to not require cutting-edge spice bits to build ... > > > > I only increased the protocol requirement, not the server. > > Distros tend to update those in sync, so this doesn't help much for the > average user, this change would likely cause spice detection fail on > almost every released distro ... You're right. This would be solved with a submodule. > > > Meanwhile I'll add a define based on the pkg-config spice-protocol > > version, which I can test from hw/qxl.c, since the commit adding > > QXL_IO_MONITORS_CONFIG_ASYNC didn't introduce any new define I can > > check. > > Just checking "SPICE_SERVER_VERSION >= 0x000b01" doesn't work? I'd > expect spice-server 0.11.1+ having a dependency on a recent enougth > spice-protocol so you can expect QXL_IO_MONITORS_CONFIG_ASYNC being > present then, no? Since spice-server now uses submodules, it doesn't check for an external spice-protocol, so no. > > thanks, > Gerd >