Re: [Qemu-devel] [PATCH 5/5] qmp: add SUSPEND_DISK event

[Luiz Capitulino <lcapitulino@redhat.com>]

On Thu, 09 Aug 2012 13:51:10 -0600
Eric Blake <eblake@redhat.com> wrote:

> On 08/09/2012 11:30 AM, Luiz Capitulino wrote:
> > Emitted when the guest makes a request to enter S4 state.
> > 
> > There are three possible ways of having this event, as described here:
> > 
> >  http://lists.gnu.org/archive/html/qemu-devel/2012-07/msg02307.html
> > 
> > I've decided to add a new event and make it indepedent of SHUTDOWN.
> > This means that the SHUTDOWN event will eventually follow the
> > SUSPEND_DISK event.
> > 
> > I've choosen this way because of two reasons:
> > 
> >  1. Having an indepedent event makes it possible to query for its
> >     existence by using query-events
> > 
> >  2. In the future, we may allow the user to change what QEMU should
> >     do as a result of the guest entering S4. So it's a good idea to
> >     keep both events separated
> 
> Indeed makes sense as a separate event.
> 
> > 
> > Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> > ---
> > 
> > This is on top of:
> > 
> >  [PATCH 0/4]: qmp: WAKEUP event related fixes
> > 
> >  QMP/qmp-events.txt | 14 ++++++++++++++
> >  hw/acpi.c          |  2 ++
> >  monitor.c          |  1 +
> >  monitor.h          |  1 +
> >  4 files changed, 18 insertions(+)
> > 
> > diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt
> > index 2001a71..1c51bee 100644
> > --- a/QMP/qmp-events.txt
> > +++ b/QMP/qmp-events.txt
> > @@ -252,6 +252,20 @@ Example:
> >  { "event": "SUSPEND",
> >       "timestamp": { "seconds": 1344456160, "microseconds": 309119 } }
> >  
> > +SUSPEND_DISK
> > +------------
> > +
> > +Emitted when the guest makes a request to enter S4 state.
> > +
> > +Data: None.
> > +
> > +Example:
> > +
> > +{ "event": "SUSPEND_DISK",
> > +     "timestamp": { "seconds": 1344456160, "microseconds": 309119 } }
> > +
> > +Note: QEMU shutdowns when entering S4 state.
> 
> s/shutdowns/shuts down/
> 
> Is that true when you use the -no-shutdown flag?  Do you get this event
> if you did not use the -no-shutdown flag?

Yes, the event is orthogonal to the -no-shutdown flag, but qemu won't
shut down if -no-shutdown is passed. I'll fix that note.