From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37728) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SzZeD-0007q1-9G for qemu-devel@nongnu.org; Thu, 09 Aug 2012 16:48:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SzZeC-0002zk-1a for qemu-devel@nongnu.org; Thu, 09 Aug 2012 16:48:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53799) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SzZeB-0002ze-Pd for qemu-devel@nongnu.org; Thu, 09 Aug 2012 16:47:59 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q79Klwlf005578 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 9 Aug 2012 16:47:58 -0400 Date: Thu, 9 Aug 2012 17:48:34 -0300 From: Luiz Capitulino Message-ID: <20120809174834.5cb3c977@doriath.home> In-Reply-To: <502414AE.3080105@redhat.com> References: <20120809143032.44b147fe@doriath.home> <502414AE.3080105@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 5/5] qmp: add SUSPEND_DISK event List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: mkletzan@redhat.com, qemu-devel , gleb@redhat.com, kraxel@redhat.com On Thu, 09 Aug 2012 13:51:10 -0600 Eric Blake wrote: > On 08/09/2012 11:30 AM, Luiz Capitulino wrote: > > Emitted when the guest makes a request to enter S4 state. > > > > There are three possible ways of having this event, as described here: > > > > http://lists.gnu.org/archive/html/qemu-devel/2012-07/msg02307.html > > > > I've decided to add a new event and make it indepedent of SHUTDOWN. > > This means that the SHUTDOWN event will eventually follow the > > SUSPEND_DISK event. > > > > I've choosen this way because of two reasons: > > > > 1. Having an indepedent event makes it possible to query for its > > existence by using query-events > > > > 2. In the future, we may allow the user to change what QEMU should > > do as a result of the guest entering S4. So it's a good idea to > > keep both events separated > > Indeed makes sense as a separate event. > > > > > Signed-off-by: Luiz Capitulino > > --- > > > > This is on top of: > > > > [PATCH 0/4]: qmp: WAKEUP event related fixes > > > > QMP/qmp-events.txt | 14 ++++++++++++++ > > hw/acpi.c | 2 ++ > > monitor.c | 1 + > > monitor.h | 1 + > > 4 files changed, 18 insertions(+) > > > > diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt > > index 2001a71..1c51bee 100644 > > --- a/QMP/qmp-events.txt > > +++ b/QMP/qmp-events.txt > > @@ -252,6 +252,20 @@ Example: > > { "event": "SUSPEND", > > "timestamp": { "seconds": 1344456160, "microseconds": 309119 } } > > > > +SUSPEND_DISK > > +------------ > > + > > +Emitted when the guest makes a request to enter S4 state. > > + > > +Data: None. > > + > > +Example: > > + > > +{ "event": "SUSPEND_DISK", > > + "timestamp": { "seconds": 1344456160, "microseconds": 309119 } } > > + > > +Note: QEMU shutdowns when entering S4 state. > > s/shutdowns/shuts down/ > > Is that true when you use the -no-shutdown flag? Do you get this event > if you did not use the -no-shutdown flag? Yes, the event is orthogonal to the -no-shutdown flag, but qemu won't shut down if -no-shutdown is passed. I'll fix that note.