qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Luigi Rizzo <rizzo@iet.unipi.it>,
	Jan Kiszka <jan.kiszka@siemens.de>,
	qemu-devel@nongnu.org,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] net: notify iothread after flushing queue
Date: Fri, 10 Aug 2012 07:59:30 +0100	[thread overview]
Message-ID: <20120810065930.GA30898@stefanha-thinkpad.localdomain> (raw)
In-Reply-To: <CAAu8pHvLjyB_LSxjWb88R73bJbgtNpEy0cyZHSzm=-u1P6zHVw@mail.gmail.com>

On Thu, Aug 09, 2012 at 05:55:50PM +0000, Blue Swirl wrote:
> On Thu, Aug 9, 2012 at 2:45 PM, Paolo Bonzini <pbonzini@redhat.com> wrote:
> > @@ -244,7 +244,7 @@ void qemu_net_queue_flush(NetQueue *queue)
> >                                       packet->size);
> >          if (ret == 0) {
> >              QTAILQ_INSERT_HEAD(&queue->packets, packet, entry);
> > -            break;
> > +            return 0;
> 
> return false;
> 
> >          }
> >
> >          if (packet->sent_cb) {
> > @@ -253,4 +253,5 @@ void qemu_net_queue_flush(NetQueue *queue)
> >
> >          g_free(packet);
> >      }
> > +    return 1;
> 
> return true;

Will fix these up when merging.  I think it's clearer to use bool too.

Stefan

  reply	other threads:[~2012-08-10  8:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-09 14:45 [Qemu-devel] [PATCH 0/3] net: add missing queue flush for e1000 and xen Paolo Bonzini
2012-08-09 14:45 ` [Qemu-devel] [PATCH 1/3] net: notify iothread after flushing queue Paolo Bonzini
2012-08-09 17:55   ` Blue Swirl
2012-08-10  6:59     ` Stefan Hajnoczi [this message]
2012-08-09 14:45 ` [Qemu-devel] [PATCH 2/3] e1000: flush queue whenever can_receive can go from false to true Paolo Bonzini
2012-08-09 14:45 ` [Qemu-devel] [PATCH 3/3] xen: flush queue when getting an event Paolo Bonzini
2012-08-09 15:16 ` [Qemu-devel] [PATCH 0/3] net: add missing queue flush for e1000 and xen Stefan Hajnoczi
2012-08-09 15:18   ` Stefano Stabellini
2012-08-30  2:32 ` Amos Kong
  -- strict thread matches above, loose matches on Subject: below --
2012-08-10 13:27 [Qemu-devel] [PULL 0/3] Net patches Stefan Hajnoczi
2012-08-10 13:27 ` [Qemu-devel] [PATCH 1/3] net: notify iothread after flushing queue Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120810065930.GA30898@stefanha-thinkpad.localdomain \
    --to=stefanha@linux.vnet.ibm.com \
    --cc=blauwirbel@gmail.com \
    --cc=jan.kiszka@siemens.de \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rizzo@iet.unipi.it \
    --cc=stefano.stabellini@eu.citrix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).