From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:60065)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@linux.vnet.ibm.com>) id 1SzkPh-000272-2R
	for qemu-devel@nongnu.org; Fri, 10 Aug 2012 04:17:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@linux.vnet.ibm.com>) id 1SzkPg-0002eQ-1W
	for qemu-devel@nongnu.org; Fri, 10 Aug 2012 04:17:45 -0400
Received: from e06smtp18.uk.ibm.com ([195.75.94.114]:48625)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@linux.vnet.ibm.com>) id 1SzkPf-0002eK-PW
	for qemu-devel@nongnu.org; Fri, 10 Aug 2012 04:17:43 -0400
Received: from /spool/local
	by e06smtp18.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <stefanha@linux.vnet.ibm.com>;
	Fri, 10 Aug 2012 09:17:42 +0100
Received: from d06av05.portsmouth.uk.ibm.com (d06av05.portsmouth.uk.ibm.com
	[9.149.37.229])
	by b06cxnps3075.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with
	ESMTP id q7A8HX9V21758092
	for <qemu-devel@nongnu.org>; Fri, 10 Aug 2012 08:17:33 GMT
Received: from d06av05.portsmouth.uk.ibm.com (loopback [127.0.0.1])
	by d06av05.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with
	ESMTP id q7A8HOqd010956
	for <qemu-devel@nongnu.org>; Fri, 10 Aug 2012 02:17:25 -0600
Date: Fri, 10 Aug 2012 07:59:30 +0100
From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Message-ID: <20120810065930.GA30898@stefanha-thinkpad.localdomain>
References: <1344523557-28266-1-git-send-email-pbonzini@redhat.com>
	<1344523557-28266-2-git-send-email-pbonzini@redhat.com>
	<CAAu8pHvLjyB_LSxjWb88R73bJbgtNpEy0cyZHSzm=-u1P6zHVw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAAu8pHvLjyB_LSxjWb88R73bJbgtNpEy0cyZHSzm=-u1P6zHVw@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] net: notify iothread after flushing
 queue
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Luigi Rizzo <rizzo@iet.unipi.it>, Jan Kiszka <jan.kiszka@siemens.de>, qemu-devel@nongnu.org, Stefano Stabellini <stefano.stabellini@eu.citrix.com>

On Thu, Aug 09, 2012 at 05:55:50PM +0000, Blue Swirl wrote:
> On Thu, Aug 9, 2012 at 2:45 PM, Paolo Bonzini <pbonzini@redhat.com> wrote:
> > @@ -244,7 +244,7 @@ void qemu_net_queue_flush(NetQueue *queue)
> >                                       packet->size);
> >          if (ret == 0) {
> >              QTAILQ_INSERT_HEAD(&queue->packets, packet, entry);
> > -            break;
> > +            return 0;
> 
> return false;
> 
> >          }
> >
> >          if (packet->sent_cb) {
> > @@ -253,4 +253,5 @@ void qemu_net_queue_flush(NetQueue *queue)
> >
> >          g_free(packet);
> >      }
> > +    return 1;
> 
> return true;

Will fix these up when merging.  I think it's clearer to use bool too.

Stefan