From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36819) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SzqKA-0000Qz-V1 for qemu-devel@nongnu.org; Fri, 10 Aug 2012 10:36:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SzqKA-0000rR-4m for qemu-devel@nongnu.org; Fri, 10 Aug 2012 10:36:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:5031) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SzqK9-0000qg-TN for qemu-devel@nongnu.org; Fri, 10 Aug 2012 10:36:26 -0400 Date: Fri, 10 Aug 2012 11:36:53 -0300 From: Luiz Capitulino Message-ID: <20120810113653.620067fa@doriath.home> In-Reply-To: <87628rce76.fsf@blackfin.pond.sub.org> References: <1344354826-10375-1-git-send-email-lcapitulino@redhat.com> <1344354826-10375-14-git-send-email-lcapitulino@redhat.com> <87628rce76.fsf@blackfin.pond.sub.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 13/35] hmp_change(): don't access DeviceEncrypted's data List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, pbonzini@redhat.com, eblake@redhat.com On Fri, 10 Aug 2012 11:02:21 +0200 Markus Armbruster wrote: > Luiz Capitulino writes: > > > It's not needed. The device name is already known and > > monitor_read_block_device_key() knows how to do the rest. This overly > > simplifies hmp_change(). > > "overly"? > > My usual complaint about commit messages is that they fail to explain > the change's purpose. Yours explains your reason just fine, but the > description of what's done falls a bit short. I'd like to see something > like "replace duplicated password prompting code by common > monitor_read_block_device_key()". Done, for v3.