From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:54235)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1SzqTv-0000HV-0f
	for qemu-devel@nongnu.org; Fri, 10 Aug 2012 10:46:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1SzqTr-0004fh-Ov
	for qemu-devel@nongnu.org; Fri, 10 Aug 2012 10:46:30 -0400
Received: from mx1.redhat.com ([209.132.183.28]:12364)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1SzqTr-0004f9-Gl
	for qemu-devel@nongnu.org; Fri, 10 Aug 2012 10:46:27 -0400
Date: Fri, 10 Aug 2012 11:47:00 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20120810114700.31c95a5c@doriath.home>
In-Reply-To: <871ujfcdxy.fsf@blackfin.pond.sub.org>
References: <1344354826-10375-1-git-send-email-lcapitulino@redhat.com>
	<1344354826-10375-15-git-send-email-lcapitulino@redhat.com>
	<871ujfcdxy.fsf@blackfin.pond.sub.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 14/35] net: inet_connect(),
 inet_connect_opts(): add in_progress argument
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: kwolf@redhat.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, pbonzini@redhat.com, eblake@redhat.com

On Fri, 10 Aug 2012 11:07:53 +0200
Markus Armbruster <armbru@redhat.com> wrote:

> Luiz Capitulino <lcapitulino@redhat.com> writes:
> 
> > It's used to indicate the special case where a valid file-descriptor
> > is returned (ie. success) but the connection can't be completed
> > w/o blocking.
> 
> Why callers need that isn't obvious from this patch.  It's used in PATCH
> 16.  Either squash the two to make it obvious, or furher explain the
> purpose in this commit message.  I'd recommend the former.

Done for v3.