From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:58934)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1T0ujz-0006tr-Dk
	for qemu-devel@nongnu.org; Mon, 13 Aug 2012 09:31:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1T0ujt-0008HV-Gy
	for qemu-devel@nongnu.org; Mon, 13 Aug 2012 09:31:31 -0400
Received: from mx1.redhat.com ([209.132.183.28]:52759)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1T0ujt-0008HO-8x
	for qemu-devel@nongnu.org; Mon, 13 Aug 2012 09:31:25 -0400
Date: Mon, 13 Aug 2012 10:32:03 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20120813103203.541d03e5@doriath.home>
In-Reply-To: <87has9nc1u.fsf@blackfin.pond.sub.org>
References: <1344620653-29067-1-git-send-email-lcapitulino@redhat.com>
	<87has9nc1u.fsf@blackfin.pond.sub.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 00/35]: add new error format
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: kwolf@redhat.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, pbonzini@redhat.com, eblake@redhat.com

On Sat, 11 Aug 2012 09:05:33 +0200
Markus Armbruster <armbru@redhat.com> wrote:

> Luiz Capitulino <lcapitulino@redhat.com> writes:
> 
> [...]
> > This series implements the 'Plan for error handling in QMP' as described
> > by Anthony in this email:
> >
> >     http://lists.gnu.org/archive/html/qemu-devel/2012-07/msg03764.html
> >
> > Basically, this replaces almost all error classes by GenericError (the
> > exception are a few error classes used by libvirt) and drops the error
> > data memeber. This also adds a free form string to error_set().
> >
> > On the wire, we go from:
> >
> >     { "error": { "class": "DeviceNotRemovable",
> >                  "data": { "device": "virtio0" },
> >                  "desc": "Device 'virtio0' is not removable" } }
> >
> > to:
> >
> >      { "error": { "class": "GenericError",
> >                   "desc": "Device 'virtio0' is not removable" } }
> >
> > Internally, we go from:
> >
> >   void error_set(Error **err, const char *fmt, ...);
> >
> > to:
> >
> >   void error_set(Error **err, ErrorClass err_class, const char *fmt, ...);
> 
> Glad to see this change in good shape in time for the release.  Thanks,
> Luiz!

Thank you for your review!

> 
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
>