From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55471) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T11gN-0007Ky-Lc for qemu-devel@nongnu.org; Mon, 13 Aug 2012 16:56:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T11gL-00011z-5Q for qemu-devel@nongnu.org; Mon, 13 Aug 2012 16:56:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45580) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T11gK-00011k-SM for qemu-devel@nongnu.org; Mon, 13 Aug 2012 16:56:13 -0400 Date: Mon, 13 Aug 2012 17:45:23 -0300 From: Marcelo Tosatti Message-ID: <20120813204523.GB10099@amt.cnet> References: <1344272705-17825-1-git-send-email-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] kvm-all.c: Move init of irqchip_inject_ioctl out of kvm_irqchip_create() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: patches@linaro.org, Jan Kiszka , qemu-devel@nongnu.org, kvm@vger.kernel.org, Avi Kivity On Sun, Aug 12, 2012 at 02:13:52PM +0100, Peter Maydell wrote: > Ping? I don't think this one quite made it into Avi's pullreq... Please post this with the rest of the code to support the new s->irqchip_inject_ioctl value. > thanks > -- PMM > > On 6 August 2012 18:05, Peter Maydell wrote: > > Move the init of the irqchip_inject_ioctl field of KVMState out of > > kvm_irqchip_create() and into kvm_init(), so that kvm_set_irq() > > can be used even when no irqchip is created (for architectures > > that support async interrupt notification even without an in > > kernel irqchip). > > > > Signed-off-by: Peter Maydell > > --- > > We can't just set irqchip_inject_ioctl in target-*/kvm.c because > > the KVMState struct layout is private to kvm-all.c. Moving the > > default initialisation of this field seemed the simplest approach. > > It's safe because the use in kvm_set_irq() is guarded by a check of > > kvm_async_interrupts_enabled(). > > > > The other approach would be to have a helper function for setting > > the field, but that seems overkill when KVM_IRQ_LINE is the standard > > default value. (KVM_IRQ_LINE_STATUS seems to be undocumented, > > incidentally. I am going to assume it's another x86ism until somebody > > does document it :-)) > > > > kvm-all.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/kvm-all.c b/kvm-all.c > > index 6def6c9..9a1f001 100644 > > --- a/kvm-all.c > > +++ b/kvm-all.c > > @@ -1200,7 +1200,6 @@ static int kvm_irqchip_create(KVMState *s) > > return ret; > > } > > > > - s->irqchip_inject_ioctl = KVM_IRQ_LINE; > > if (kvm_check_extension(s, KVM_CAP_IRQ_INJECT_STATUS)) { > > s->irqchip_inject_ioctl = KVM_IRQ_LINE_STATUS; > > } > > @@ -1321,6 +1320,8 @@ int kvm_init(void) > > s->direct_msi = (kvm_check_extension(s, KVM_CAP_SIGNAL_MSI) > 0); > > #endif > > > > + s->irqchip_inject_ioctl = KVM_IRQ_LINE; > > + > > ret = kvm_arch_init(s); > > if (ret < 0) { > > goto err; > > -- > > 1.7.9.5 > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html