From: Luiz Capitulino <lcapitulino@redhat.com>
To: Alberto Garcia <agarcia@igalia.com>
Cc: qemu-trivial@nongnu.org, Stefan Hajnoczi <stefanha@gmail.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] ivshmem, qdev-monitor: fix order of qerror parameters
Date: Tue, 14 Aug 2012 11:43:03 -0300 [thread overview]
Message-ID: <20120814114303.4e65b24b@doriath.home> (raw)
In-Reply-To: <20120814141537.GA27231@igalia.com>
On Tue, 14 Aug 2012 16:15:37 +0200
Alberto Garcia <agarcia@igalia.com> wrote:
> On Tue, Aug 14, 2012 at 10:42:30AM -0300, Luiz Capitulino wrote:
>
> > Additionally, we should check all old QERR_ macros to see if anyone
> > else swaps parameters like this and change them too.
>
> Yes, I also noticed the problem and checked all QERR_ macros, I only
> found the two that I corrected in the patch, but double checking the
> list won't hurt I guess :)
Yes, you're right. I've just double checked it and these are the only
two cases and both have only one single user.
This patch is fine then:
Reviewed-by: Luiz Capitulino <lcapitulino@redhat.com>
prev parent reply other threads:[~2012-08-14 14:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1344944488-27075-1-git-send-email-agarcia@igalia.com>
2012-08-14 13:42 ` [Qemu-devel] [PATCH] ivshmem, qdev-monitor: fix order of qerror parameters Luiz Capitulino
2012-08-14 14:15 ` Alberto Garcia
2012-08-14 14:43 ` Luiz Capitulino [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120814114303.4e65b24b@doriath.home \
--to=lcapitulino@redhat.com \
--cc=agarcia@igalia.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).