From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58244) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1IKT-0008FL-Ns for qemu-devel@nongnu.org; Tue, 14 Aug 2012 10:42:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T1IKR-0005lI-JU for qemu-devel@nongnu.org; Tue, 14 Aug 2012 10:42:45 -0400 Date: Tue, 14 Aug 2012 11:43:03 -0300 From: Luiz Capitulino Message-ID: <20120814114303.4e65b24b@doriath.home> In-Reply-To: <20120814141537.GA27231@igalia.com> References: <1344944488-27075-1-git-send-email-agarcia@igalia.com> <20120814104230.64aed4e3@doriath.home> <20120814141537.GA27231@igalia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] ivshmem, qdev-monitor: fix order of qerror parameters List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia Cc: qemu-trivial@nongnu.org, Stefan Hajnoczi , qemu-devel On Tue, 14 Aug 2012 16:15:37 +0200 Alberto Garcia wrote: > On Tue, Aug 14, 2012 at 10:42:30AM -0300, Luiz Capitulino wrote: > > > Additionally, we should check all old QERR_ macros to see if anyone > > else swaps parameters like this and change them too. > > Yes, I also noticed the problem and checked all QERR_ macros, I only > found the two that I corrected in the patch, but double checking the > list won't hurt I guess :) Yes, you're right. I've just double checked it and these are the only two cases and both have only one single user. This patch is fine then: Reviewed-by: Luiz Capitulino